Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let user by default commit the session #112

Closed
joegasewicz opened this issue May 13, 2021 · 0 comments
Closed

Let user by default commit the session #112

joegasewicz opened this issue May 13, 2021 · 0 comments
Assignees
@joegasewicz
Labels
enhancement New feature or request

Comments

@joegasewicz
Copy link
Owner

joegasewicz commented May 13, 2021 •
edited
Loading

Let user by default commit the session as this follows best practises.

Add a new method called add_files which will only add the file meta data to the model but will not commit or save the changes.

In the README.md and docs this method should be the recommended method to use, the save_files method will be an alternative if required.
@joegasewicz joegasewicz self-assigned this May 13, 2021
@joegasewicz joegasewicz added the enhancement New feature or request label May 13, 2021
joegasewicz added a commit that referenced this issue May 13, 2021
@joegasewicz
- not setting commit_session should warn not throw
7bc1fd0 
- Let user by default commit the session
Fixes #113, #112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joegasewicz joegasewicz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joegasewicz