Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not setting commit_session should warn not throw #113

Closed
joegasewicz opened this issue May 13, 2021 · 0 comments · Fixed by #114
Closed

not setting commit_session should warn not throw #113

joegasewicz opened this issue May 13, 2021 · 0 comments · Fixed by #114
Assignees
@joegasewicz
Labels
bug Something isn't working

Comments

@joegasewicz
Copy link
Owner

Currently if commit_session is set to false it raises but only requires a warning.
@joegasewicz joegasewicz added the bug Something isn't working label May 13, 2021
@joegasewicz joegasewicz self-assigned this May 13, 2021
joegasewicz added a commit that referenced this issue May 13, 2021
@joegasewicz
- not setting commit_session should warn not throw
510e693 
Fixes #113
@joegasewicz joegasewicz mentioned this issue May 13, 2021
Merged
joegasewicz added a commit that referenced this issue May 13, 2021
@joegasewicz
- not setting commit_session should warn not throw
7bc1fd0 
- Let user by default commit the session
Fixes #113, #112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joegasewicz joegasewicz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

- not setting commit_session should warn not throw joegasewicz/flask-file-upload
1 participant
@joegasewicz