Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Fix Livewire component registration #317

Merged
merged 5 commits into from
Nov 21, 2023

Conversation

SRWieZ
Copy link
Contributor

@SRWieZ SRWieZ commented Nov 20, 2023

Summary

Fix Unable to find component with livewire v3.2.0

Explanation

I don't know what exact changes made between 3.1 to 3.2 is causing this problem but my pull request fix the error anyway

Screenshot for context
image

Checklist

  • I've read this template
  • I've checked reviewed this PR myself, ensuring consistency and quality with the rest of the project
  • I've given a good reason as to why this PR exposes new / removes existing user data

@joelbutcher
Copy link
Owner

joelbutcher commented Nov 20, 2023

@SRWieZ Looks like Jetstream had a similar issue which was fixed here: laravel/jetstream#1390 (see livewire/livewire#7076 (comment))

I've checked the PR, please can you update it to follow Jetstream's way of registering components. E.g.

if (config('jetstream.stack') === 'livewire' && class_exists(Livewire::class)) {
    Livewire::component(...);
}

Happy to approve once those changes have been made :)

@SRWieZ
Copy link
Contributor Author

SRWieZ commented Nov 20, 2023

Done! Didn't read the comment from livewire repo at first, so it taken me 3 commits to have it right 😄 Tested, it works!

@joelbutcher joelbutcher changed the title Fix for Livewire v3.2.0 [5.x] Fix Livewire component registration Nov 21, 2023
@joelbutcher joelbutcher merged commit 24230f6 into joelbutcher:5.x Nov 21, 2023
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants