Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for the possibility of not including code_insee or code_postal #6

Closed
joelgombin opened this issue Jan 30, 2017 · 1 comment
Closed

Allow for the possibility of not including code_insee or code_postal #6

joelgombin opened this issue Jan 30, 2017 · 1 comment
Assignees
@joelgombin

Comments

@joelgombin
Copy link
Owner

This fails:

library(tibble)
library(banR)
df <- tribble(~ ville,
        "Agen",
        "Ajaccio")
ban_geocode(df, "ville")
#> Error in uqs(vars): `x` must be a vector
@joelgombin joelgombin self-assigned this Jan 30, 2017
joelgombin added a commit that referenced this issue Jan 31, 2017
@joelgombin
- simplification de la gestion de la NSE
bcf70ef 
- spécification explicite du délimiteur de CSV pour l'API (voir BaseAdresseNationale/adresse.data.gouv.fr#57)
- adaptation du parseur de CSV
- stabilisation de la classe de l'output
- adaptation des tests
- création d'un test pour input avec une seule colonne (voir #6)
@joelgombin
Copy link
Owner Author

Résolu par bcf70ef

@briatte briatte mentioned this issue Mar 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joelgombin joelgombin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joelgombin