Skip to content

Commit

Permalink
getting cran comments ready for release
Browse files Browse the repository at this point in the history
  • Loading branch information
joelgombin committed May 10, 2020
1 parent ca89d9c commit cd20cc0
Showing 1 changed file with 17 additions and 16 deletions.
33 changes: 17 additions & 16 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,22 +1,23 @@
## Resubmission
This is a resubmission. In this version I have:

* corrected the use of backticks and quotes for functions and software nawes in DESCRIPTION.
## Test environments
* local R installation (Ubuntu 20.04), R 4.0.0
* Github Actions, macOS-latest, R 4.0.0
* Github Actions, window-latest, R 4.0.0
* Github Actions, Ubuntu 16.04, R 4.0.0
* Github Actions, Ubuntu 16.04, R 3.6.0
* Github Actions, Ubuntu 16.04, R 3.5.0
* Github Actions, Ubuntu 16.04, R 3.4.0
* Github Actions, Ubuntu 16.04, R 3.3.0

mac-OS latest with R-devel fails in Github Actions, but I believe that this is because no binary version of sf is available for it.

## Test environments
* local Ubuntu 16.04 install, R 3.4.1
* ubuntu 14.04.5 (on travis-ci), R 3.4.0
* win-builder (devel and release)
Please note that, due to dependency conflicts for `sf` 0.9, testing may fail in some environments. It is in particular the case for rhub, which does not allow to use the ubuntugis-unstable PPA necessary to get the necessary versions of GDAL, GEOS and PROJ4 for sf 0.9. This is why I favored Github Actions.

## R CMD check results
There were no ERRORs or WARNINGs.

There was 1 NOTE on win-builder:
0 errors | 0 warnings | 0 note

* This is a new release.

## Downstream dependencies

* checking CRAN incoming feasibility ... NOTE
Maintainer: 'Joël Gombin <joel.gombin@gmail.com>'
New submission
Possibly mis-spelled words in DESCRIPTION:
concaveman (11:19, 11:50)
mapbox (11:115)
I ran `revdepcheck::revdep_check()`. There is no problem with the downstream dependencies.

0 comments on commit cd20cc0

Please sign in to comment.