Added benchmark for FlatFiles#26
Merged
Merged
Conversation
Closed
| { | ||
| var values = csvReader.GetValues(); | ||
| var record = activate(); | ||
| record.Read(i => values[i]?.ToString() ?? string.Empty); |
Owner
There was a problem hiding this comment.
Is the first ? necessary? When would values[i] return null? Ideally we have minimal null coalescence since that is extra operations and will yield worse performance.
Contributor
Author
There was a problem hiding this comment.
It is null instead of an empty string when the field is empty. Maybe there's a setting to change that.
Contributor
Author
There was a problem hiding this comment.
I don't see anything in options. If you have a faster way of checking for a null and returning a string if it is, let me know. I have never performance tested that scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.