Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persisting Commits #26

Closed
5 tasks done
joepio opened this issue Oct 10, 2020 · 0 comments
Closed
5 tasks done

Persisting Commits #26

joepio opened this issue Oct 10, 2020 · 0 comments

Comments

@joepio
Copy link
Member

joepio commented Oct 10, 2020

Commits are atomic changes to a resource. If these are persisted, we can use these to generate logs and previous versions. Pretty cool.

I think it makes sense to simply store these as resources (since they are just that) - not as some special struct.

One thing I'm still pondering about, is how to deal with failed commits. For now, if a commit cannot be applied, it will not be stored. This works fine for synchronous APIs (e.g. posting a Commit to a /commit endpoint), but this would not work when these commits are sent in bulk.

For the future:

  • Generate commits when importing atomic data (parsing ad3, for example)
  • Limit write access to the commit API (maybe)
  • Start thinking about how to generate older versions of resources, and how to query these resources (probably TPF)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant