Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is Stupid-Table-Plugin browser support in November 2014 ? #128

Closed
0xadri opened this issue Nov 17, 2014 · 6 comments
Closed

What is Stupid-Table-Plugin browser support in November 2014 ? #128

0xadri opened this issue Nov 17, 2014 · 6 comments

Comments

@0xadri
Copy link
Contributor

0xadri commented Nov 17, 2014

Hi,

I cannot find any clear statement regarding browser support.

I did a bit of research but could not find anything.

Ideally I am looking for an official statement from the creator of the plugin or by someone who has been using this plugin on Live systems for a while.

Thanks in advance,
Adrien

@joequery
Copy link
Owner

Hey Adrien,

You can run the unittests in any browser by visiting

https://rawgit.com/joequery/Stupid-Table-Plugin/master/tests/test.html

I haven't made any official statement of browser support, but I can look into some sort of service that will let me test multiple browser versions.

@0xadri
Copy link
Contributor Author

0xadri commented Nov 17, 2014

Hi Joe

Thanks for the quick feedback. That's great, I'll run this test in a few different browsers & will post back the results I got.

Yes, maybe browserstack, saucelabs, ghostLab, or spoon could do the job.

@joequery
Copy link
Owner

👍 Thank you for the service recommendations

@0xadri
Copy link
Contributor Author

0xadri commented Nov 18, 2014

Test results on different setups:

  • Windows OS (7) + Firefox 33: OK
  • Windows OS (7) + Chrome 38 : OK
  • Windows OS (7) + IE11: seems fine1
  • Windows OS (7) + IE10: seems fine1
  • Windows OS (XP) + IE8: seems fine1 and 2
  • iPad + Safari: OK
  • iPad + Chrome: OK
  • Samsung S3 mini + Android + Chrome: seems fine2
  • Samsung S3 mini + Android + Firefox: seems fine2
  • iPhone 4S + iOS + Safari: seems fine2

1: test fix needed as test 13 fails. Fix this by getting the value of the inline style before acting on the table & then compare it with the inline style after it. Explanation: IE modifies the inline styling properties (see more below).
2: test fix needed as tests 5 & 18 fail. Fix this by increasing "window.WAIT_TIME_MS" to "200". Explanation: slow browsers need more time to apply expected changes.

IE modifies the inline styling properties

Basically, IE modifies the inline styling for the table's tbody, and adds "currentColor; border-image: none;". God knows why.... IE will always be IE.
See by yourself by looking at this example on IE11 http://jsbin.com/hogud/3/edit
This is what you will see: http://i.imgur.com/diyaUFu.png

Conclusion

It looks all pretty good to me. More browser testing across device would be nice (IE9, browsers on Android tablets & possibly other Android mobiles).
I will submit some pull requests to fix the mentioned Unit Tests fixes.

0xadri added a commit to 0xadri/Stupid-Table-Plugin that referenced this issue Nov 18, 2014
This fixes issues with tests 5 and 18 as mentioned in joequery#128

Explanation: slow browsers need more time to apply expected changes.
0xadri added a commit to 0xadri/Stupid-Table-Plugin that referenced this issue Nov 18, 2014
IE has some strange behavior. It modifies the value of the inline styling, as fully explained on joequery#128

Best thing to avoid this silly problem is to simply compare the inline styling before any JS is run "on the relevant table element". And then compare this value with the one after the relevant JS is run.
@joequery
Copy link
Owner

Adrien,

Thank you so much for your contributions! I appreciate your time and thorough research. I'll be sure to add browser support to the docs. The docs need an overhaul anyhow.

@0xadri
Copy link
Contributor Author

0xadri commented Nov 18, 2014

You're welcome. Nice one, this will be appreciated I'm sure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants