Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All special edition downloaders should be using the same file for all OS #21

Closed
joergi opened this issue May 6, 2020 · 0 comments · Fixed by #28
Closed

All special edition downloaders should be using the same file for all OS #21

joergi opened this issue May 6, 2020 · 0 comments · Fixed by #28
Assignees
@joergi
Labels
enhancement good first issue good starting issue to get involve help wanted Linux OS Mac OS Windows OS this is all related to the windows version

Comments

@joergi
Copy link
Owner

joergi commented May 6, 2020

At the moment the Linux and the Windows downloaders don't have the sources duplicated.
For each special downloader should be a file which only contains the links, and the downloaders should deal with it

For example:
Windows for Essentials_Games_v1: https://github.com/joergi/MagPiDownloader/blob/master/windows/magpi-special-issue-downloader.ps1#L21
Linux for Essentials_Games_v1: https://github.com/joergi/MagPiDownloader/blob/master/linux_mac/magpi-special-issue-downloader.sh#L21

keep it simple, one file to serve both downloaders.

Similar to joergi/HackspaceMagazineDownloader#5
@joergi joergi added enhancement help wanted Windows OS this is all related to the windows version Linux OS Mac OS good first issue good starting issue to get involve labels May 6, 2020
@joergi joergi mentioned this issue May 6, 2020
Closed
@joergi joergi self-assigned this May 9, 2020
joergi added a commit that referenced this issue Jun 1, 2020
@joergi
Issues #21 refactoring the sources of the issues to download
572fc1c
@joergi joergi mentioned this issue Jun 1, 2020
Merged
joergi added a commit that referenced this issue Jun 1, 2020
@joergi
Issues #21 writing all the special issues and books in an extra file.
6863a98
joergi added a commit that referenced this issue Jul 28, 2020
@joergi
Issues #21 refactoring the sources of the issues to download (#28)
9bb81c0 
* Issues #21 refactoring the sources of the issues to download

* update from issue 93 to 94

* Issues #21 writing all the special issues and books in an extra file.

* renaming

* updating to issue 95

* fixing downloader file

* removing not needed stuff

* use downloader 0.3.0 for special-issues and normal ones

* use downloader 0.3.0 for special-issues and normal ones

* fixing linter issues

* using main version v0.3.0 of downloader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joergi joergi

Labels
enhancement good first issue good starting issue to get involve help wanted Linux OS Mac OS Windows OS this is all related to the windows version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issues #21 refactoring the sources of the issues to download joergi/MagPiDownloader
1 participant
@joergi