Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues #21 refactoring the sources of the issues to download #28

Merged
merged 15 commits into from Jul 28, 2020
Merged

Issues #21 refactoring the sources of the issues to download #28

merged 15 commits into from Jul 28, 2020

Conversation

joergi
Copy link
Owner

@joergi joergi commented Jun 1, 2020

close #21

using a single file for all OS

@joergi joergi added Linux OS Mac OS Windows OS this is all related to the windows version enhancement labels Jun 1, 2020
@joergi joergi changed the base branch from master to main July 26, 2020 20:43
@rubemlrm
Copy link
Contributor

@joergi can we merge this already? Or do you want to fix the travis-ci and codacy not running steps ?

@joergi
Copy link
Owner Author

joergi commented Jul 28, 2020

It's a draft 😉
But I will sit later at my pc and finish some stuff

@rubemlrm
Copy link
Contributor

It's a draft 😉
But I will sit later at my pc and finish some stuff

roger that =)

@joergi
merge main to branch
8997948
@joergi
Merge branch 'issue-21_All_special_edition_downloaders_should_be_usin…
fdcb303 
…g_the_same_file_for_all_OS' of github.com:joergi/MagPiDownloader into issue-21_All_special_edition_downloaders_should_be_using_the_same_file_for_all_OS
@joergi
fixing downloader file
a4cab98
@joergi
removing not needed stuff
c0c2345
@joergi
Copy link
Owner Author

joergi commented Jul 28, 2020

First fix: https://github.com/joergi/WireframeDownloader/pull/6/files

@joergi joergi marked this pull request as ready for review July 28, 2020 23:35
@joergi joergi merged commit 9bb81c0 into main Jul 28, 2020
@joergi joergi deleted the issue-21_All_special_edition_downloaders_should_be_using_the_same_file_for_all_OS branch July 28, 2020 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Linux OS Mac OS Windows OS this is all related to the windows version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All special edition downloaders should be using the same file for all OS
2 participants
@joergi @rubemlrm