fix all the downloaders / tests

.github/workflows/linters.yml

@@ -2,23 +2,25 @@
 
 name: LINTERS
 
-# Controls when the action will run. Triggers the workflow on push or pull request
+# Controls when the action will run.
+# Triggers the workflow on push or pull request
 # events but only for the main branch
 on:
   push:
-    branches: [ main ]
+    branches: [main]
   pull_request:
-    branches: [ main ]
+    branches: [main]
 
-# A workflow run is made up of one or more jobs that can run sequentially or in parallel
+# A workflow run is made up of one or more jobs
+# that can run sequentially or in parallel
 jobs:
   lint_powershell:
     runs-on: ubuntu-latest
     name: Lint Powershell Code Base
     steps:
       - uses: actions/checkout@v3.1.0
       - name: Super-Linter
-        uses: docker://github/super-linter:v3
+        uses: docker://github/super-linter:v4
         env:
            VALIDATE_ALL_CODEBASE: true
            VALIDATE_POWERSHELL: true
@@ -29,19 +31,19 @@ jobs:
     steps:
       - uses: actions/checkout@v3.1.0
       - name: Super-Linter
-        uses: docker://github/super-linter:v3
+        uses: docker://github/super-linter:v4
         env:
            VALIDATE_ALL_CODEBASE: true
            VALIDATE_BASH: true
            GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-  lint_docker:
-    runs-on: ubuntu-latest
-    name: Lint Docker Base
-    steps:
-      - uses: actions/checkout@v3.1.0
-      - name: Super-Linter
-        uses: docker://github/super-linter:v3
-        env:
-           VALIDATE_ALL_CODEBASE: true
-           VALIDATE_DOCKER: true
-           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+#  lint_docker:
+#    runs-on: ubuntu-latest
+#    name: Lint Docker Base
+#    steps:
+#      - uses: actions/checkout@v3.1.0
+#      - name: Super-Linter
+#        uses: docker://github/super-linter:v4
+#        env:
+#           VALIDATE_ALL_CODEBASE: true
+#           VALIDATE_DOCKER: true
+#           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/testing-educational-issues.yml

@@ -39,31 +39,6 @@ jobs:
       - name: Download Education Issues
         id: educationIssues
         run: bash ./linux_mac/magpi-education-downloader.sh
-      - name: Download Issues with end limit
-        id: normalIssuesWithEndLimit
-        run: bash ./linux_mac/magpi-issue-downloader.sh -l 2
-      - name: Download Issues with start limit
-        id: normalIssuesWithStartLimit
-        run: bash ./linux_mac/magpi-issue-downloader.sh -f 99
-      - name: Download Issues with start and end limit
-        id: normalIssuesWithRange
-        run: bash ./linux_mac/magpi-issue-downloader.sh -f 95 -l 96
-      - name: Download French Issues
-        id: frenchIssues
-        run: bash ./linux_mac/magpi-issue-downloader_french.sh
-      - name: Download Hebrew Issues
-        id: hebrewIssues
-        run: bash ./linux_mac/magpi-issue-downloader_hebrew.sh
-      - name: Download Italian Issues
-        id: italianIssues
-        run: bash ./linux_mac/magpi-issue-downloader_italian.sh
-      - name: Download Spanish Issues
-        id: spanishIssues
-        run: bash ./linux_mac/magpi-issue-downloader_spanish.sh
-      - name: Download Special Issues
-        id: specialIssues
-        run: bash ./linux_mac/magpi-special-issue-downloader.sh
-      # check if files are existing
       - name: "Check file existence Linux"
         id: check_files
         uses: andstor/file-existence-action@v1.1.0
@@ -82,31 +57,6 @@ jobs:
       - name: Download Education Issues
         id: educationIssues
         run: bash ./linux_mac/magpi-education-downloader.sh
-      - name: Download Issues with end limit
-        id: normalIssuesWithEndLimit
-        run: bash ./linux_mac/magpi-issue-downloader.sh -l 2
-      - name: Download Issues with start limit
-        id: normalIssuesWithStartLimit
-        run: bash ./linux_mac/magpi-issue-downloader.sh -f 99
-      - name: Download Issues with start and end limit
-        id: normalIssuesWithRange
-        run: bash ./linux_mac/magpi-issue-downloader.sh -f 95 -l 96
-      - name: Download French Issues
-        id: frenchIssues
-        run: bash ./linux_mac/magpi-issue-downloader_french.sh
-      - name: Download Hebrew Issues
-        id: hebrewIssues
-        run: bash ./linux_mac/magpi-issue-downloader_hebrew.sh
-      - name: Download Italian Issues
-        id: italianIssues
-        run: bash ./linux_mac/magpi-issue-downloader_italian.sh
-      - name: Download Spanish Issues
-        id: spanishIssues
-        run: bash ./linux_mac/magpi-issue-downloader_spanish.sh
-      - name: Download Special Issues
-        id: specialIssues
-        run: bash ./linux_mac/magpi-special-issue-downloader.sh
-      # check if files are existing
       - name: "Check file existence MacOs"
         id: check_files
         uses: andstor/file-existence-action@v1.1.0
@@ -117,4 +67,4 @@ jobs:
         run: ls -lah education_issues
       - name: File exists
         if: steps.check_files.outputs.files_exists == 'false'
-        run: exit 1   
+        run: exit 1

.github/workflows/testing-language-issues.yml

@@ -1,6 +1,6 @@
 # This is a basic workflow to help you get started with Actions
 
-name: Testing language issues
+name: Language Issues Test Scripts
 
 # Controls when the action will run. Triggers the workflow on push or pull request
 # events but only for the main branch
@@ -12,19 +12,6 @@ on:
 
 # A workflow run is made up of one or more jobs that can run sequentially or in parallel
 jobs:
-  read_recent_issue:
-    runs-on: ubuntu-latest
-
-    steps:
-    - uses: actions/checkout@v3.1.0
-    - uses: pCYSl5EDgo/cat@master
-      id: read_recent
-      with:
-        path: issues.txt
-    - run: echo $TEXT
-      env:
-        TEXT: ${{ steps.read_recent.outputs.text }}
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
   powershell:
     runs-on: windows-latest
     steps:
@@ -52,175 +39,10 @@ jobs:
           files: "french_issues/MagPi_Mini_French_01.pdf, italian_issues/MagPi_Mini_Italian_02.pdf, hebrew_issues/MagPi_Mini_Hebrew_01.pdf, spanish_issues/MagPi_Mini_Spanish_03.pdf"
           allow_failure: false
       - name: lslah issues
-        run: Get-ChildItem –pat## This is a basic workflow to help you get started with Actions
-#
-#name: Test Scripts
-#
-## Controls when the action will run. Triggers the workflow on push or pull request
-## events but only for the main branch
-#on:
-#  push:
-#    branches: [ main ]
-#  pull_request:
-#    branches: [ main ]
-#
-## A workflow run is made up of one or more jobs that can run sequentially or in parallel
-#jobs:
-#  read_recent_issue:
-#    runs-on: ubuntu-latest
-#
-#    steps:
-#    - uses: actions/checkout@v3.1.0
-#    - uses: pCYSl5EDgo/cat@master
-#      id: read_recent
-#      with:
-#        path: issues.txt
-#    - run: echo $TEXT
-#      env:
-#        TEXT: ${{ steps.read_recent.outputs.text }}
-#        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-#  powershell:
-#    runs-on: windows-latest
-#    steps:
-#      - uses: actions/checkout@v3.1.0
-#      - name: Download Education Issues
-#        id: educationIssues
-#        shell: pwsh
-#        run: ./windows/magpi-education-downloader.ps1
-#      - name: Download Issues With end limit
-#        id: normalIssuesWithEndLimit
-#        shell: pwsh
-#        run: ./windows/magpi-issue-downloader.ps1 -l 3
-#      - name: Download Issues with start and end limit
-#        id: normalIssuesWithRange
-#        shell: pwsh
-#        run: ./windows/magpi-issue-downloader.ps1 -f 95 -l 96
-#      - name: Download Issues with start and end limit
-#        id: normalIssuesWithStartingLimit
-#        shell: pwsh
-#        run: ./windows/magpi-issue-downloader.ps1 -f 99
-#      - name: Download French Issues
-#        id: frenchIssues
-#        shell: pwsh
-#        run: ./windows/magpi-issue-downloader_french.ps1
-#      - name: Download Hebrew Issues
-#        id: hebrewIssues
-#        shell: pwsh
-#        run: ./windows/magpi-issue-downloader_hebrew.ps1
-#      - name: Download Italian Issues
-#        id: italianIssues
-#        shell: pwsh
-#        run: ./windows/magpi-issue-downloader_italian.ps1
-#      - name: Download Spanish Issues
-#        id: spanishIssues
-#        shell: pwsh
-#        run: ./windows/magpi-issue-downloader_spanish.ps1
-#      - name: Download Special Issues
-#        id: specialIssues
-#        shell: pwsh
-#        run: ./windows/magpi-special-issue-downloader.ps1
-#      - name: "Check file existence Windows"
-#        id: check_files
-#        uses: andstor/file-existence-action@v1.1.0
-#        with:
-#          files: "issues/the-magpi-issue-3.pdf, issues/the-magpi-issue-96.pdf, issues/the-magpi-issue-101.pdf, french_issues/MagPi_Mini_French_01.pdf, italian_issues/MagPi_Mini_Italian_02.pdf, hebrew_issues/MagPi_Mini_Hebrew_01.pdf, spanish_issues/MagPi_Mini_Spanish_03.pdf, special_issues/Essentials_Games_v1.pdf"
-#          allow_failure: false
-#      - name: lslah issues
-#        run: Get-ChildItem –path D:\a\MagPiDownloader\MagPiDownloader\issues,D:\a\MagPiDownloader\MagPiDownloader\french_issues,D:\a\MagPiDownloader\MagPiDownloader\italian_issues,D:\a\MagPiDownloader\MagPiDownloader\hebrew_issues,D:\a\MagPiDownloader\MagPiDownloader\spanish_issues,D:\a\MagPiDownloader\MagPiDownloader\special_issues
-#      - name: File exists
-#        if: steps.check_files.outputs.files_exists == 'false'
-#        run: exit 1
-#
-#  bash-linux:
-#    runs-on: ubuntu-latest
-#    steps:
-#      - uses: actions/checkout@v3.1.0
-#      - name: Download Education Issues
-#        id: educationIssues
-#        run: bash ./linux_mac/magpi-education-downloader.sh
-#      - name: Download Issues with end limit
-#        id: normalIssuesWithEndLimit
-#        run: bash ./linux_mac/magpi-issue-downloader.sh -l 2
-#      - name: Download Issues with start limit
-#        id: normalIssuesWithStartLimit
-#        run: bash ./linux_mac/magpi-issue-downloader.sh -f 99
-#      - name: Download Issues with start and end limit
-#        id: normalIssuesWithRange
-#        run: bash ./linux_mac/magpi-issue-downloader.sh -f 95 -l 96
-#      - name: Download French Issues
-#        id: frenchIssues
-#        run: bash ./linux_mac/magpi-issue-downloader_french.sh
-#      - name: Download Hebrew Issues
-#        id: hebrewIssues
-#        run: bash ./linux_mac/magpi-issue-downloader_hebrew.sh
-#      - name: Download Italian Issues
-#        id: italianIssues
-#        run: bash ./linux_mac/magpi-issue-downloader_italian.sh
-#      - name: Download Spanish Issues
-#        id: spanishIssues
-#        run: bash ./linux_mac/magpi-issue-downloader_spanish.sh
-#      - name: Download Special Issues
-#        id: specialIssues
-#        run: bash ./linux_mac/magpi-special-issue-downloader.sh
-## check if files are existing
-#      - name: "Check file existence Linux"
-#        id: check_files
-#        uses: andstor/file-existence-action@v1.1.0
-#        with:
-#          files: "issues/MagPi02.pdf, issues/MagPi96.pdf, issues/MagPi101.pdf, french_issues/MagPi_Mini_French_01.pdf, italian_issues/MagPi_Mini_Italian_02.pdf, hebrew_issues/MagPi_Mini_Hebrew_01.pdf, spanish_issues/MagPi_Mini_Spanish_03.pdf, special_issues/MagPiSE1.pdf, special_issues/Projects_Book_v3.pdf, special_issues/Essentials_Camera_v1.pdf, special_issues/Retro_Gaming.pdf, special_issues/Camera-Guide.pdf"
-#          allow_failure: false
-#      - name: lslah
-#        run: ls -lah  issues/ french_issues/ italian_issues/ hebrew_issues/ spanish_issues/ special_issues/
-#      - name: File exists
-#        if: steps.check_files.outputs.files_exists == 'false'
-#        run: exit 1
-#  bash-macos:
-#    runs-on: macos-latest
-#    steps:
-#      - uses: actions/checkout@v3.1.0
-#      - name: Download Education Issues
-#        id: educationIssues
-#        run: bash ./linux_mac/magpi-education-downloader.sh
-#      - name: Download Issues with end limit
-#        id: normalIssuesWithEndLimit
-#        run: bash ./linux_mac/magpi-issue-downloader.sh -l 2
-#      - name: Download Issues with start limit
-#        id: normalIssuesWithStartLimit
-#        run: bash ./linux_mac/magpi-issue-downloader.sh -f 99
-#      - name: Download Issues with start and end limit
-#        id: normalIssuesWithRange
-#        run: bash ./linux_mac/magpi-issue-downloader.sh -f 95 -l 96
-#      - name: Download French Issues
-#        id: frenchIssues
-#        run: bash ./linux_mac/magpi-issue-downloader_french.sh
-#      - name: Download Hebrew Issues
-#        id: hebrewIssues
-#        run: bash ./linux_mac/magpi-issue-downloader_hebrew.sh
-#      - name: Download Italian Issues
-#        id: italianIssues
-#        run: bash ./linux_mac/magpi-issue-downloader_italian.sh
-#      - name: Download Spanish Issues
-#        id: spanishIssues
-#        run: bash ./linux_mac/magpi-issue-downloader_spanish.sh
-#      - name: Download Special Issues
-#        id: specialIssues
-#        run: bash ./linux_mac/magpi-special-issue-downloader.sh
-## check if files are existing
-#      - name: "Check file existence MacOs"
-#        id: check_files
-#        uses: andstor/file-existence-action@v1.1.0
-#        with:
-#          files: "issues/MagPi02.pdf, issues/MagPi95.pdf, issues/MagPi101.pdf, french_issues/MagPi_Mini_French_01.pdf, italian_issues/MagPi_Mini_Italian_02.pdf, hebrew_issues/MagPi_Mini_Hebrew_01.pdf, spanish_issues/MagPi_Mini_Spanish_03.pdf, special_issues/MagPiSE1.pdf, special_issues/Projects_Book_v3.pdf, special_issues/Essentials_Camera_v1.pdf, special_issues/Retro_Gaming.pdf, special_issues/Camera-Guide.pdf"
-#          allow_failure: false
-#      - name: lslah
-#        run: ls -lah issues/ french_issues/ italian_issues/ hebrew_issues/ spanish_issues/ special_issues/
-#      - name: File exists
-#        if: steps.check_files.outputs.files_exists == 'false'
-#        run: exit 1
-h D:\a\MagPiDownloader\MagPiDownloader\french_issues,D:\a\MagPiDownloader\MagPiDownloader\italian_issues,D:\a\MagPiDownloader\MagPiDownloader\hebrew_issues,D:\a\MagPiDownloader\MagPiDownloader\spanish_issues
+        run: Get-ChildItem –path D:\a\MagPiDownloader\MagPiDownloader\french_issues,D:\a\MagPiDownloader\MagPiDownloader\italian_issues,D:\a\MagPiDownloader\MagPiDownloader\hebrew_issues,D:\a\MagPiDownloader\MagPiDownloader\spanish_issues
       - name: File exists
         if: steps.check_files.outputs.files_exists == 'false'
-        run: exit 1  
+        run: exit 1
 
   bash-linux:
     runs-on: ubuntu-latest
@@ -238,18 +60,17 @@ h D:\a\MagPiDownloader\MagPiDownloader\french_issues,D:\a\MagPiDownloader\MagPiD
       - name: Download Spanish Issues
         id: spanishIssues
         run: bash ./linux_mac/magpi-issue-downloader_spanish.sh
-# check if files are existing        
       - name: "Check file existence Linux"
         id: check_files
         uses: andstor/file-existence-action@v1.1.0
         with:
           files: "french_issues/MagPi_Mini_French_01.pdf, italian_issues/MagPi_Mini_Italian_02.pdf, hebrew_issues/MagPi_Mini_Hebrew_01.pdf, spanish_issues/MagPi_Mini_Spanish_03.pdf"
           allow_failure: false
       - name: lslah
-        run: ls -lah  issues/ french_issues/ italian_issues/ hebrew_issues/ spanish_issues/ special_issues/      
+        run: ls -lah french_issues/ italian_issues/ hebrew_issues/ spanish_issues/
       - name: File exists
         if: steps.check_files.outputs.files_exists == 'false'
-        run: exit 1   
+        run: exit 1
   bash-macos:
     runs-on: macos-latest
     steps:
@@ -266,7 +87,6 @@ h D:\a\MagPiDownloader\MagPiDownloader\french_issues,D:\a\MagPiDownloader\MagPiD
       - name: Download Spanish Issues
         id: spanishIssues
         run: bash ./linux_mac/magpi-issue-downloader_spanish.sh
-# check if files are existing
       - name: "Check file existence MacOs"
         id: check_files
         uses: andstor/file-existence-action@v1.1.0
@@ -277,4 +97,4 @@ h D:\a\MagPiDownloader\MagPiDownloader\french_issues,D:\a\MagPiDownloader\MagPiD
         run: ls -lah french_issues/ italian_issues/ hebrew_issues/ spanish_issues/
       - name: File exists
         if: steps.check_files.outputs.files_exists == 'false'
-        run: exit 1   
+        run: exit 1