[dataflowengineoss] globalFromLit only when it's a standalone assignment #4559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch looks coherent, I see the |
DavidBakerEffendi
approved these changes
May 15, 2024
xavierpinho
commented
May 15, 2024
| @@ -16,14 +16,12 @@ class SingleAssignmentTests extends RubyCode2CpgFixture(withPostProcessing = tru | |||
| val source = cpg.literal.l | |||
| val sink = cpg.method.name("puts").callIn.argument.l | |||
| val flows = sink.reachableByFlows(source).map(flowToResultPairs).distinct.sortBy(_.length).l | |||
| flows.size shouldBe 6 | |||
| val List(flow1, flow2, flow3, flow4, flow5, flow6) = flows | |||
| val List(flow1, flow2, flow3, flow4, flow5) = flows | |||
There was a problem hiding this comment.
The previously called flow3 is removed, but I reckon the new flow4 covers it better.
xavierpinho
force-pushed
the
xavierp/global-from-lit
branch
from
fd39e8f
to
183de17
Compare
|
Was actually expecting more tests to fail, as I don't have the required setup locally to test all frontends. Turns out there was only 7 of them and all on ruby. Took the opportunity to make those flow tests more explicit, instead of just looking at their sizes. Please kindly see if the changes committed after your approval still make sense, @DavidBakerEffendi |
xavierpinho
force-pushed
the
xavierp/global-from-lit
branch
from
183de17
to
56c4de8
Compare
karan-batavia
pushed a commit
to Privado-Inc/joern
that referenced
this pull request
Jun 18, 2024
…ent (joernio#4559) * [dataflowengineoss] globalFromLit trigger only when it's a standalone assignment * fix unit-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4549, we noticed an extra flow in the following sample:
This was traced to
globalFromLiteral, in which the statementx = foo(20)would considerx, adding it to the starting points of the query.In this patch we only trigger if the literal is the RHS of the assignment.
I may be missing some relevant context here that I didn't gather from the failing unit-tests. Before going through the trouble of fixing them all, is this patch coherent?
EDIT: Resolves #4549