Refactor Signer class #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reused in Twisted and/or Tornado.
…uest() now accepts a parameter list
|
@robkinyon Thanks a lot for this patch. I'd love to get it merged in, but @jaitaiwan and I have been merging in other PRs and it looks like this needs to be updated with |
|
Further to @joestump's comment it would be awesome if you could also squash your commits too before submitting the PR. Thanks! |
|
It's been a couple years (and a couple jobs) since I created this PR. I'm going to have to rebuild my fork and put my changeset on a proper branch before I can figure this out. Give me a few weeks. |
|
Thanks @robkinyon! Much appreciated. Will need to resubmit the PR against the develop branch so I'll leave this open as a reminder till we get the new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow oauth2 to be usable in asynchronous frameworks such as Twisted or Tornado. Currently, the Signer class is commingled into the Client class, forcing all usage of signed requests to be over httplib2, thus synchronous. By breaking the act of signing out from the act of making the request, oauth2 becomes usable in asynchronous frameworks.