Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style editor to work on chrome windows #314

Closed
wants to merge 4 commits into from

Conversation

harthur
Copy link
Collaborator

@harthur harthur commented Nov 29, 2012

This PR will allow the Style Editor to debug chrome window targets. I'm using this scratchpad to test it: https://gist.github.com/4a1c22f41e99da2511ae

@harthur
Copy link
Collaborator Author

harthur commented Nov 29, 2012

My bad, works on Dev Tools windows but not browser windows. But, it's progress, still think it could be checked in.

@harthur
Copy link
Collaborator Author

harthur commented Nov 29, 2012

jk, it did work on browser windows, it just so happened most browser css files had an @import rule at the beginning and that was causing a HierarchyRequestError (can't insert before an @import rule). This last commit fixes that by inserting the transition rules at the end of the stylesheet.

t+

@paulrouget
Copy link

I'm surprised how simple this is: http://i.imgur.com/zvpEu.jpg

@paulrouget
Copy link

Heather, does your bugzilla patch include your latest commit?

@paulrouget
Copy link

We landed that.

@paulrouget paulrouget closed this Dec 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants