runat-1128988: Having functions called 'eval' seems dangerous

I tried using GCLI from babel and it didn't like to have functions called 'eval'. It looks legal under ES5 'strict mode' to me, but I don't think eval is a good name all the same. Signed-off-by: Joe Walker <jwalker@mozilla.com>
joewalker · Mar 17, 2015 · 4dc4581 · 4dc4581 · bgrins · Mar 19, 2015
1 parent de35726
commit 4dc4581
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/lib/gcli/languages/javascript.js b/lib/gcli/languages/javascript.js
@@ -42,8 +42,7 @@ exports.items = [
     },
 
     exec: function(input) {
-      return this.eval(input).then(function(response) {
-        // console.log('javascript.exec', response);
+      return this.evaluate(input).then(function(response) {
         var output = (response.exception != null) ?
                       response.exception.class :
                       response.output;
@@ -80,8 +79,8 @@ exports.items = [
       }.bind(this));
     },
 
-    eval: function(input) {
-      return host.script.eval(input);
+    evaluate: function(input) {
+      return host.script.evaluate(input);
     }
   }
 ];
diff --git a/lib/gcli/util/host.js b/lib/gcli/util/host.js
@@ -177,7 +177,7 @@ exports.script = {
   useTarget: function(tgt) { },
 
   // Execute some JavaScript
-  eval: function(javascript) {
+  evaluate: function(javascript) {
     try {
       return Promise.resolve({
         input: javascript,

diff --git a/web/gcli/util/host.js b/web/gcli/util/host.js
@@ -164,7 +164,7 @@ exports.script = {
   useTarget: function(tgt) { },
 
   // Execute some JavaScript
-  eval: function(javascript) {
+  evaluate: function(javascript) {
     try {
       return Promise.resolve({
         input: javascript,