Add minValueScale option

[megawac]

Obvious compliment to maxValueScale. I was looking for it and was a bit surprised it wasn't about

[drewnoakes]

Looks good! I'll do some testing asap and merge this in if all works well. Thanks.

[megawac]

Actually this doesn't work too hot for negative values in the scale. Give me a sec I'm refactoring this

[megawac]

Eh, that will do I guess -- ping @drewnoakes

[drewnoakes]

Nice spot on the fix. Actually you've identified a bug in the maxValueScale scenario too that manifests when the maximum value is negative. Hope to look at merging this in the next evening or two.

[drewnoakes]

There is actually one minor glitch with this PR.

In the case of maxValueScale, a value less than 1 (say, 0.8) creates a negative margin, such that the series may spill outside the chart area.

With this minValueScale implementation, a value less than 1 has the same effect as a value that's greater than 1.

Would you have a chance to look at it? If so, I'll hold off on tagging the release.

[megawac]

Sure i can fix that tonight but why would someone use a value less than 1
On Nov 25, 2014 5:32 PM, "Drew Noakes" notifications@github.com wrote:

There is actually one minor glitch with this PR.

In the case of maxValueScale, a value less than 1 (say, 0.8) creates a
negative margin, such that the series may spill outside the chart area.

With this minValueScale implementation, a value less than 1 has the same
effect as a value that's greater than 1.

Would you have a chance to look at it? If so, I'll hold off on tagging the
release.

—
Reply to this email directly or view it on GitHub
#54 (comment).

[drewnoakes]

Haha, well I thought the same thing about minValueScale but I'm sure you had a good reason to want it :) Perhaps a value < 1 would be useful to crop outliers... not very convincing, but there may be a use case. At any rate, it'd be less potentially surprising if both settings behaved in the same way.

[megawac]

Agreed, though we probably should be using the range say (scale * (max - min)) * val - val sound good?