Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #575 Add window title match support in Group config section #576

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

BertranAsylum
Copy link
Contributor

Now you can specify "Title" match in "Group" section:

<Group>
    <Title>Some window title</Title>
    <!-- ... -->
</Group>

@BertranAsylum
Copy link
Contributor Author

My bad, duplicates #519

@joewing
Copy link
Owner

joewing commented Jun 13, 2022

It appears that I'm fighting a losing battle with this one 😄
Because the title can change and may not even be set when the window is mapped, I tend to think it's a bad idea to use the window title for matching. On the other hand, this particular thing has been implemented twice before (PRs #265 and #519) and it's been requested at least three times now (issues #234, #416 and now #575).
So I'm thinking I may just let this go through (I might just update the documentation at some point to reflect the fact that this match only runs when the window initially appears).
I guess the question is which PR... The three PRs are very similar, but all use a different name for the tag. Though I have to admit, I like "Title" the best!

@BertranAsylum
Copy link
Contributor Author

BertranAsylum commented Jun 14, 2022

It appears that I'm fighting a losing battle with this one 😄
Because the title can change and may not even be set when the window is mapped, I tend to think it's a bad idea to use the window title for matching. On the other hand, this particular thing has been implemented twice before (PRs #265 and #519) and it's been requested at least three times now (issues #234, #416 and now #575).
So I'm thinking I may just let this go through (I might just update the documentation at some point to reflect the fact that this match only runs when the window initially appears).
I guess the question is which PR... The three PRs are very similar, but all use a different name for the tag. Though I have to admit, I like "Title" the best!

What about title changes monitoring and remap if title match. Probably, more wasteful than useful..

@joewing joewing merged commit d8d4f54 into joewing:master Jun 14, 2022
@joewing
Copy link
Owner

joewing commented Jun 14, 2022

Thanks!
I went ahead and merged this one. Probably fine as is without making it more complicated.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants