Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #388 - psmelt now works when ntaxa == 1 #373

Closed
wants to merge 2 commits into from
Closed

Fixed #388 - psmelt now works when ntaxa == 1 #373

wants to merge 2 commits into from

Conversation

audy
Copy link
Contributor

@audy audy commented Aug 7, 2014

No description provided.

@joey711 joey711 mentioned this pull request Aug 7, 2014
Closed
joey711 added a commit that referenced this pull request Aug 8, 2014
@joey711
1.9.12 Fix smelt bug with single-OTU data
3daeab4 
CHANGES IN VERSION 1.9.12
-------------------------

BUG FIXES

	- `psmelt` function now properly handles single-OTU data

	- Related to #338

	- Builds on #373
@joey711
Copy link
Owner

joey711 commented Aug 8, 2014

@audy

Note that I received an automated indicator that I could not automatically merge this PR. The reason is due in large part to the fact that this is a very old branch. The version of phyloseq listed in this branch's package is 1.7.*. Merging would have caused all sorts of havoc, and added other objects to phyloseq that had nothing to with the name of this PR (and had been declined earlier, like the plot_timeseries function).

I appreciate the PRs, and have incorporated your suggestions in the latest version of phyloseq on the master branch (1.9.12). In the future, please limit the scope of your PR changes to exactly what you've described, and make sure that their commits start from the most recent available master.

Thanks again

joey

@joey711 joey711 closed this Aug 8, 2014
@audy
Copy link
Contributor Author

audy commented Aug 8, 2014

D'oh. I thought I was working on HEAD but I was actually a few months behind. The code for that function looks different now. I'll either revisit this on a more recent copy or travel back in time and submit a PR.

@joey711
Copy link
Owner

joey711 commented Aug 8, 2014

No worries. Just a heads up so that I can merge PRs faster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@audy @joey711