browserify _extensions taken into account #4
Conversation
|
Entschuldigung, I have 0 experience with all of this. |
|
Thanks @iccthedral. Here's the way GH does this: When you open a PR, it creates a new issue. That's intentional. Your PR description should include something about what you did, and the comment "fixes #" for an issue. (Which you did!) I've reopened this PR, and will take a look tonight. When I merge it, it'll close the issue for us and the PR. |
| , Browserify = function(opts){ | ||
| var self = this; | ||
| self._extensions = ['.js', '.json'] | ||
| .concat(opts ? opts.extensions: []).filter(Boolean) |
There was a problem hiding this comment.
Please run npm i -g jscs; jscs . There are several style errors that should be corrected.
There was a problem hiding this comment.
I remember I've ran this a month ago and there were no style errors whatsoever. I've ran it again today and there are 36 some really nonsensical (to my untrained eye) errors. Here's the output
|
Hey guys, how is this coming along? Can I do anything to help? I could really use the patch right about now :) |
|
@iccthedral any thoughts on my feedback? |
|
@joeybaker Yes, but can you guys wait for just one more day. I'm on vacation atm. |
|
Any progress on this issue? I'm still willing to help out.. |
|
@JohnRandom Sure, do you understand the problem I'm having? |
Fixes issue #3