Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected paragraphs in lists items are messing their margin up #25

Closed
qn7o opened this issue Sep 6, 2013 · 4 comments
Closed

Unexpected paragraphs in lists items are messing their margin up #25

qn7o opened this issue Sep 6, 2013 · 4 comments

Comments

@qn7o
Copy link

qn7o commented Sep 6, 2013

When using lists (any type of lists), once you introduce a paragraph inside one of the list items (by any mean: explicitly making a new paragraph or introducing a blockquote which will wrap the rest of the list item's text in a paragraph), all the following list items will be wrapped in paragraphs. You'll see it clearly in the attached screenshot.

Also, these paragraphs have a margin-top property that makes the lists look dirty once there are paragraphs inside. In the screenshot, from the Item 3, every Item have a margin-top: 15px applied, while the previous elements don't.

padding-trouble

If you'd like to test on your side, here's the source:

    * Item #1
    * Item #2  
      With a newline inside.
    * Item #3
      
      With another paragraph inside.
    * Item #4
    * Item #5

    Can also be reproduced in numbered lists and with blockquotes.

    1. Item #6
    2. Item #7
    3. Item #8
      
      > With  blockquote inside.
    4. Item #9

While I'm here, thanks a lot for Grip. It's great tool and I'm using it daily to render MD, making my doc reading sessions much more comfy !

@joeyespo
Copy link
Owner

joeyespo commented Sep 8, 2013

Hmm, I'm not so sure this is a Grip bug. Grip's purpose is to match Github exactly, and Github appears to be doing the same thing, as per the above test.

Here's a screenshot of what I see in case it's rendering differently for you.

grip paragraph test

Unless you see something different, it seems to be working properly. If it's bothering you, open an issue with Github =) Well, they don't have a public issue tracker, so use this one.

That said, to actually answer your question, you can override Github's styles locally by adding your own CSS files and telling Grip to use them:

  1. Visit the grip directory, where all the .py files are, and where the templates directory is
  2. Create a settings_local.py file and add STYLE_URLS = ['static/local.css'] to it
  3. Add a static directory
  4. Create a local.css file in the static directory and add your adjusted margin styles there

Hope this helps! And thanks, glad you like Grip =)

@joeyespo
Copy link
Owner

joeyespo commented Sep 8, 2013

@ABourguignon I just added the explanation to the project, under grip/static/README.md.

Let me know if this makes sense!

@qn7o
Copy link
Author

qn7o commented Sep 9, 2013

Hello Joe,

Great, thanks a lot for all this ! I'll still shoot an email at Github's support, just in case, because the way they are adding

in lists items still seems fuzzy. And in the meantime, I'll use the custom CSS feature.

Thanks again, kind regards, and keep up the good work !
Antonin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants