Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing icons #85

Closed
d13r opened this issue Nov 2, 2014 · 9 comments
Closed

Missing icons #85

d13r opened this issue Nov 2, 2014 · 9 comments
Labels
Milestone

Comments

@d13r
Copy link
Contributor

d13r commented Nov 2, 2014

This may be the same as #81 - the Octicons don't seem to be loading:

image

In the Chrome console log it shows it's failing to load the font:

Failed to load resource: the server responded with a status of 404 (NOT FOUND) http://192.168.32.84:5000/grip-cache/octicons/octicons/octicons-192e5fbb927be7cdb8bdfa0ecb98d3574bd395e58f9d00e5dcdfce5bc9660ac0.woff
Failed to load resource: the server responded with a status of 404 (NOT FOUND) http://192.168.32.84:5000/grip-cache/octicons/octicons/octicons-1b8fabf8a76f5d60ef9999b3fcf5e06b9f563148d6215465df8952fdbb9aa3ec.ttf

And the same items appear in the SSH console:

192.168.32.84 - - [02/Nov/2014 17:24:02] "GET /grip-cache/octicons/octicons/octicons-192e5fbb927be7cdb8bdfa0ecb98d3574bd395e58f9d00e5dcdfce5bc9660ac0.woff HTTP/1.1" 404 -
192.168.32.84 - - [02/Nov/2014 17:24:02] "GET /grip-cache/octicons/octicons/octicons-1b8fabf8a76f5d60ef9999b3fcf5e06b9f563148d6215465df8952fdbb9aa3ec.ttf HTTP/1.1" 404 -

I have the latest version:

$ grip --version
Grip 3.0.0

I have tried reinstalling Grip and clearing the cache also:

$ sudo pip uninstall grip
$ sudo pip install grip
$ grip --clear

I've also checked it in Firefox and IE - it's not working there either.

Any ideas?
Thanks

@hrubi
Copy link

hrubi commented Dec 4, 2014

One problem is, that the files are in the root directory of the grip cache, but are being fetched from nested directory.

# find ~/.grip/cache-3.0.0 -name 'octicons*'
/home/hrubi/.grip/cache-3.0.0/octicons-7f0c4ab57d5e4fce26440514dd399d7e5c356485584baf201b4ac751055b6e32.svg
/home/hrubi/.grip/cache-3.0.0/octicons-192e5fbb927be7cdb8bdfa0ecb98d3574bd395e58f9d00e5dcdfce5bc9660ac0.woff
/home/hrubi/.grip/cache-3.0.0/octicons-1b8fabf8a76f5d60ef9999b3fcf5e06b9f563148d6215465df8952fdbb9aa3ec.ttf
/home/hrubi/.grip/cache-3.0.0/octicons-bg-f51579234572c7286b1ead7a6408f2d43c7a0520dbb09f9d2b8b6b59024a01a0.png
/home/hrubi/.grip/cache-3.0.0/octicons-50f7c541d70d63b9d9e905389ae12f4f9f6e3e632b4c7e0655c9ef955ff0b092.eot

I've tried as a workaround:

ln -s . ~/.grip/cache-3.0.0/octicons

Now I get correctly 200 (or 304), but the icons do not show anyway. So there must be some additional problem.

@qn7o
Copy link

qn7o commented Jan 14, 2015

It affects me as well, a bit sad because it degrades the sleek and neat look'n'feel.

@madflow madflow mentioned this issue Jan 16, 2015
@joeyespo
Copy link
Owner

joeyespo commented Feb 6, 2015

Fixed with #95.

@joeyespo joeyespo closed this as completed Feb 6, 2015
@joeyespo joeyespo added the bug label Feb 7, 2015
@joeyespo joeyespo added this to the 3.1 milestone Feb 7, 2015
@joeyespo
Copy link
Owner

joeyespo commented Feb 9, 2015

FYI, I just released 3.1.0 which fixes this. Be sure to pip install --upgrade grip. Thanks for your patience, everyone!

@d13r
Copy link
Contributor Author

d13r commented Feb 9, 2015

Great, thank you 👍

@qn7o
Copy link

qn7o commented Feb 15, 2015

Many thanks !

@akaleeroy
Copy link

Icons still 404 in 3.3.0

@joeyespo
Copy link
Owner

@akaleeroy Looks like GitHub changed their URL format for assets. Fixed in f04eab8. I'll publish a new release soon.

@joeyespo
Copy link
Owner

@akaleeroy FYI, released last week. pip install --upgrade grip and that should fix the latest missing icons problem. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants