Missing icons #95
Merged
Missing icons #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 16, 2015 20:09
| # Write file and show message | ||
| _write_file(filename, contents) | ||
| # Retrieve file and show message | ||
| urlretrieve(asset_url, filename) |
There was a problem hiding this comment.
Is this more robust than using requests and writing to a file?
Requests handles things like following redirects for you.
There was a problem hiding this comment.
Nevermind, I just read your description.
What was causing the "wrong file size"? Was it requests, or the _write_file? If it's _write_file, that should probably be fixed instead of worked around so that other uses of function don't fail.
|
Just tested it and it works. Nice job! Thanks for the fix, @madflow! |
|
This is great, thanks ! |
|
Just released a new version with your fix. Be sure to |
|
👍 Thanks for the merge . Let's see which new bugs I introduced with this :D |
|
@madflow 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible fix for #85. The problem seems to be twofold:
requests.get(asset_url, verify=False).textseemed to bail on .woff etc files (wrong file size)<path:filename>route did not match the icons url.This is a typical "works for me" hack - maybe it does some good ;)