Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3ify all the things #54

Merged
merged 3 commits into from
Apr 28, 2014
Merged

python3ify all the things #54

merged 3 commits into from
Apr 28, 2014

Conversation

bsdlp
Copy link
Contributor

@bsdlp bsdlp commented Apr 28, 2014

#16

@bsdlp
Copy link
Contributor Author

bsdlp commented Apr 28, 2014

CSS rendering doesn't seem to work correctly, investigating, might be something to do with unicode handling in py3?

It would be great if tests were added 😄

@bsdlp
Copy link
Contributor Author

bsdlp commented Apr 28, 2014

c396952 fixes the style loading issue.

Markdown==2.3.1
Jinja2==2.7.2
Markdown==2.4
MarkupSafe==0.21
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you planning on using this?

@joeyespo
Copy link
Owner

Going to remove the dependencies itsdangerous and MarkupSafe since they're not used by Grip directly, but other than that this looks good. I tested this on my Python 2.7 environment and it's working well.

Thanks for this PR, @fly!

joeyespo added a commit that referenced this pull request Apr 28, 2014
python3ify all the things
@joeyespo joeyespo merged commit fc80db8 into joeyespo:master Apr 28, 2014
This was referenced Apr 28, 2014
@joeyespo joeyespo added this to the 2.1 milestone Jun 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants