Add polling options for remote file systems #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,6 +15,7 @@ | |||
| --onpass=<cmd> Run arbitrary programs on pass. | |||
| --onfail=<cmd> Run arbitrary programs on failure. | |||
| --nobeep Do not beep on failure. | |||
| --poll Use polling instead of events (useful in VMs) | |||
There was a problem hiding this comment.
Ah, good idea to call out why this is here! 👍
|
This looks good! The lag is interesting. I wonder if it's the observer setting up the complete map of file polling services before having any one of them report a chance. Without Thanks for taking this on, @carsongee! |
joeyespo
added a commit
that referenced
this pull request
May 8, 2015
Add polling options for remote file systems
|
No problem, thanks for the merge, and I'll go ahead and make an issue on watchdog |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add the default polling observer if
--pollis given to the command. Something worth noting, is that even for one of my smallest projects there is a bit of a lag in startup time before it starts getting file changes, so when testing I had to wait a few seconds after the first test ran before it would register file changes. After that lag, it worked pretty well.Closes #9