Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passing args to py.test on POSIX systems #18

Merged
merged 1 commit into from
Jun 27, 2015
Merged

Fix passing args to py.test on POSIX systems #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pytest_watch/watcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ def run(self, summary=None):
msg = ('Changes detected, rerunning: {}'
.format(highlight(command)))
print(STYLE_NORMAL + msg + Fore.RESET + Style.NORMAL)
exit_code = subprocess.call(['py.test'] + self.args, shell=True)
exit_code = subprocess.call(['py.test'] + self.args,
shell=subprocess.mswindows)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, never knew about subprocess.mswindows. There's so many ways to test what OS you're on. This one definitely seems the most explicit when doing a Windows-only check.

passed = exit_code == 0

# Beep if failed
Expand Down