Fix passing args to py.test on POSIX systems #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use shell=True only for MS Windows when executing py.test. Ref: aldanor@dc066e212#commitcomment-11887976
blueyed
referenced
this pull request
in aldanor/pytest-watch
Jun 26, 2015
This fixes the edge case when py.test arguments contained quoted strings
with spaces, e.g.:
ptw -- -m 'not slow'
| @@ -88,7 +88,8 @@ def run(self, summary=None): | |||
| msg = ('Changes detected, rerunning: {}' | |||
| .format(highlight(command))) | |||
| print(STYLE_NORMAL + msg + Fore.RESET + Style.NORMAL) | |||
| exit_code = subprocess.call(['py.test'] + self.args, shell=True) | |||
| exit_code = subprocess.call(['py.test'] + self.args, | |||
| shell=subprocess.mswindows) | |||
There was a problem hiding this comment.
Wow, never knew about subprocess.mswindows. There's so many ways to test what OS you're on. This one definitely seems the most explicit when doing a Windows-only check.
|
Thank you, @blueyed! |
joeyespo
added a commit
that referenced
this pull request
Jun 27, 2015
Fix passing args to py.test on POSIX systems
|
Just deployed |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use shell=True only for MS Windows when executing py.test.
Ref: aldanor@dc066e212#commitcomment-11887976