Fix error when no <directory> arg #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,7 +39,7 @@ def watch(directory=None, auto_clear=False, extensions=[]): | |||
| """Starts a server to render the specified file or directory containing a README.""" | |||
| if directory and not os.path.isdir(directory): | |||
| raise ValueError('Directory not found: ' + directory) | |||
| directory = os.path.abspath(directory) | |||
There was a problem hiding this comment.
Does this actually fail?
When I run os.path.absapth(None) in the interpreter, it returns the absolute path of the current working directory. (On Windows anyway.)
There was a problem hiding this comment.
I'm using OS X 10.9 and getting this:
$ python
Python 2.7.5 (default, Mar 9 2014, 22:15:05)
[GCC 4.2.1 Compatible Apple LLVM 5.0 (clang-500.0.68)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import os.path
>>> os.path.abspath(None)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py", line 352, in abspath
if not isabs(path):
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py", line 61, in isabs
return s.startswith('/')
AttributeError: 'NoneType' object has no attribute 'startswith'
>>>
|
Thanks for the fix, @rakjin! |
joeyespo
added a commit
that referenced
this pull request
Feb 5, 2015
Fix error when no <directory> arg
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case of
<directory>isNone, an error raises, as far as I tested