Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle configuration/collection errors when no pytest inifile is present. #90

Merged
merged 1 commit into from
May 20, 2018

Conversation

asford
Copy link
Contributor

@asford asford commented Apr 4, 2018

Handle config collection when no pytest inifile is present, finish config
collection via StopCollect even if an ini file is not present in the
cmdline_main configuration hook.

Resolves issues where ptw fails silently if errors are present in the
source module and an pytest.ini file is not present. See #85 #73

Handle config collection when no pytest inifile is present, finish config
collection via StopCollect even if an ini file is not present in the
cmdline_main configuration hook.

Resolves issues where `ptw` fails silently if errors are present in the
source module and an `pytest.ini` file is not present.
@asford asford changed the title Handle config when no pytest inifile is present. Handle configuration/collection errors when no pytest inifile is present. Apr 4, 2018
@joeyespo
Copy link
Owner

Hey @asford, after testing out a few different cases, I ended up with a solutions that doesn't need to move StopCollect up. I can't foresee if that'll cause other issues, so that's another reason for doing it this other way.

I'll pull this in still and keep the comment, and still tag you in Authors.md. Thanks!

@joeyespo joeyespo merged commit 40191c5 into joeyespo:master May 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants