Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homepage unresponsive: sporadic websocket connection timeout #114

Closed
joffrey-bion opened this issue Feb 10, 2021 · 1 comment
Closed

Homepage unresponsive: sporadic websocket connection timeout #114

joffrey-bion opened this issue Feb 10, 2021 · 1 comment
Labels
duplicate
Projects
Roadmap / Priorities

Comments

@joffrey-bion
Copy link
Owner

From time to time the websocket fails to connect properly.

The symptom is that the arrow button on the home page doesn't seem to have any effect.

We should at the very least show that the connection is on-going (with a loading spinner or something) and show an error if it actually times out.
@joffrey-bion joffrey-bion added the bug Affects the gameplay (gives wrong results or prevents actions) label Feb 10, 2021
@joffrey-bion joffrey-bion changed the title Homepage frozen: sporadic websocket connection timeout Homepage unresponsive: sporadic websocket connection timeout Feb 10, 2021
@joffrey-bion joffrey-bion added this to Needs triage in Roadmap / Priorities Feb 10, 2021
@joffrey-bion joffrey-bion moved this from Needs triage to High priority in Roadmap / Priorities Feb 10, 2021
@joffrey-bion
Copy link
Owner Author

joffrey-bion commented Feb 10, 2021 •
edited

Looks like it's 100% reproducible by just using the back button from the browser on the game browser page, which brings the user back to the home page.

Apparently the home saga (listening to RequestChooseName) is not started in this case, because the navigation was not triggered through redux (we probably need to look into react-router-redux).

In any case, this is superseded by the more general #116. Closing.

@joffrey-bion joffrey-bion added duplicate and removed bug Affects the gameplay (gives wrong results or prevents actions) labels Feb 10, 2021
Roadmap / Priorities automation moved this from High priority to Closed Feb 10, 2021
This was referenced Feb 10, 2021
Closed
Closed
joffrey-bion added a commit that referenced this issue Feb 10, 2021
@joffrey-bion
Properly start/stop sagas when using browser navigation
bbe342a 
Resolves:
#116

Related:
#114

Related:
#60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
Roadmap / Priorities
Closed
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joffrey-bion