Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support prev/next browser navigation #60

Closed
joffrey-bion opened this issue Dec 9, 2020 · 0 comments
Closed

Support prev/next browser navigation #60

joffrey-bion opened this issue Dec 9, 2020 · 0 comments
Labels
bug Affects the gameplay (gives wrong results or prevents actions) usability Usability issue/improvement to give a better UX

Comments

@joffrey-bion
Copy link
Owner

joffrey-bion commented Dec 9, 2020

Navigating between routes is something that people naturally do.
We need to respect all possible states in all screens to accommodate for unexpected navigations, and also add better navigation within the application itself to get back to the "expected" route.

Example problems:

  • pressing the "back" button from the game browser to go to the homepage: it doesn't properly trigger the home saga and doesn't listen to the change name event anymore (see Homepage unresponsive: sporadic websocket connection timeout #114 and Handle sagas start/stop on browser navigation #116)
  • pressing the "back" button while in the lobby: ideally the game should handle this event as a "leave lobby" action, or at the very least the browser screen should respect this state and provide a button to get back to the lobby
  • pressing back from the game browser after leaving a game from the score board button. It currently brings us back to the score board, but the game is supposed to be deleted at that moment.
@joffrey-bion joffrey-bion added the usability Usability issue/improvement to give a better UX label Dec 9, 2020
@joffrey-bion joffrey-bion changed the title Support prev/next browser navigation Support prev/next/url browser navigation Feb 8, 2021
@joffrey-bion joffrey-bion added the bug Affects the gameplay (gives wrong results or prevents actions) label Feb 10, 2021
joffrey-bion added a commit that referenced this issue Feb 10, 2021
joffrey-bion added a commit that referenced this issue Feb 10, 2021
@joffrey-bion joffrey-bion changed the title Support prev/next/url browser navigation Support prev/next browser navigation Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Affects the gameplay (gives wrong results or prevents actions) usability Usability issue/improvement to give a better UX
Projects
None yet
Development

No branches or pull requests

1 participant