Finish switch to webkitgtk 4.1 #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Merging right away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A year ago, birdfont was ported from webkitgtk 4.0 to 4.1 but dodo.py wasn't updated so I don't believe that worked.
Here is a merge request to do that and also drop a few other references to old webkit versions.
I recommend removing the old travis script instead of renaming it. It is stored in git so it is easy to restore later if needed. By that point, it would need to be updated anyway.
Copies of the vapi files should not be needed since they should be provided by the development library (libwebkit2gtk-4.1-dev on Ubuntu for instance).
webkitgtk 4.1 is the same as 4.0 except it uses libsoup3 instead of libsoup2.4. Since birdfont doesn't use libsoup directly at all, it does not need to be mentioned.