Compatibility with Chrome <= 69 (default WebView on Android <= 9.0)

[lrq3000]

Description

Add a polyfill in src/polyfills.ts for compatibility with Chrome <= 69 (default WebView on Android <= 9.0). This bug also happens with desktop versions of Chrome, not only mobile.

In practice, this PR adds compatibility for Android 9.0 and 8.1 out of the box (whereas before, only Android 10+ were compatible out of the box, without updating Chrome first). This PR does not change anything for Android 6.0+ with an updated Chrome browser, as updating Chrome always restore compatibility with super-productivity (tested on Android 7.0+ in AVD emulator, could not test Android 6.0 because of a lack of Play Store but it should be the same).

Issues Resolved

Fixes #2451, fixes johannesjo/super-productivity-android#34 .

Check List

Tested on (AVD emulator, default Chrome browser):

• Android 9.0
• Android 8.1 - SUCCESS (Chrome v61.0.3163.98)
• Android 8.0 - FAIL with default browser (Chrome v58, no error but silent infinite loading on quote of the day screen)
• Android 7.1 - FAIL (same as Android 8.0)
• Android 7.0 - FAIL (same as Android 8.0)
• Android 6.0 (SDK API 23, minimum targeted SDK version by super-productivity-android app) - FAIL (same as Android 8.0)
• Android 10
• Android 11
• Android 13

Note that updating Chrome allows super-productivity alone or combined with super-productivity-android to work on all older Android versions, the failure above are only with the default Chrome version as supplied with the older Android release.

[github-actions]

Hello there lrq3000! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

[lrq3000]

With older Chrome versions, super-productivity fails silently in an infinite loop. This is confirmed using Desktop Chrome v52 or Mobile Chrome v58 (Android 8.0). Uncommenting all default polyfills.ts does not help. Nothing is shown in the console.

To get the binaries to test an older Chrome version, search a build here:

https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html

I used build 390249 (corresponds to a v52 branch release).

So this PR is still useful to increase compatibility with older browsers but not all older browsers.

[lrq3000]

Incidentally found a fix for johannesjo/super-productivity-android#34 , now ng serve --host 0.0.0.0 --watch works as-is, no need for custom commands, and loading is fast. Works both inside and outside the AVD emulator.

/EDIT: I thought so but it ended up being a false positive, the bug is not fixed, I rollbacked the unnecessary change.

[lrq3000]

All done. PR ready to be merged.

[johannesjo]

Thank you very much once more!! I'm alright with ditching support for android versions 8 and below. The market share is not that huge and we have to focus our limited resources :)

[lrq3000]

Yes but only out of the box android <= 8.0 don't work, but if chrome is updated then the webapp is compatible down to Android 6.0 and maybe even below that too! What matters most is the browser version, so that it supports a modern javascript instructions set. 6 févr. 2023 21:02:30 Johannes Millan ***@***.***>:

…

Thank you very much once more!! I'm alright with ditching support for android versions 8 and below. The market share is not that huge and we have to focus our limited resources :) — Reply to this email directly, view it on GitHub[#2453 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAIRFXVNXADAQUXDTWWL2HDWWFKFLANCNFSM6AAAAAAURWLXLE]. You are receiving this because you authored the thread.[Image de pistage][https://github.com/notifications/beacon/AAIRFXWOIILPHTQECY7M4VTWWFKFLA5CNFSM6AAAAAAURWLXLGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSUTZZDQ.gif]