Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Object.fromEntries is not a function #2451

Closed
lrq3000 opened this issue Feb 4, 2023 · 4 comments · Fixed by #2453
Closed

TypeError: Object.fromEntries is not a function #2451

lrq3000 opened this issue Feb 4, 2023 · 4 comments · Fixed by #2453

Comments

@lrq3000
Copy link
Contributor

lrq3000 commented Feb 4, 2023

Steps to Reproduce

Just open the latest git commit version of the Android app inside an Android 9.0 AVD image (Android Studio emulator) with the app pointing to https://app.super-productivity.com, and this critical error happens after the "quote of the day", preventing any use of the app.

This bug may be fixed with the latest git release of the super-productivity webapp, I'll test that next, but just posting this error just in case.

/EDIT: same bug with locally hosted webapp on the latest super-productivity git commit.

Error Log (Desktop only)

Console Output

Stacktrace (pointing to app.super-productivity.com)

_convertKeyframesToObject (webpack:///node_modules/@angular/animations/fesm2015/browser.mjs:4516:28)
_convertKeyframesToObject (webpack:///node_modules/@angular/animations/fesm2015/browser.mjs:4515:18)
_triggerWebAnimation (webpack:///node_modules/@angular/animations/fesm2015/browser.mjs:4524:39)
_buildPlayer (webpack:///node_modules/@angular/animations/fesm2015/browser.mjs:4500:17)
init (webpack:///node_modules/@angular/animations/fesm2015/browser.mjs:4491:13)
init (webpack:///node_modules/@angular/animations/fesm2015/animations.mjs:1101:46)
init (webpack:///node_modules/@angular/animations/fesm2015/animations.mjs:1101:21)
play (webpack:///node_modules/@angular/animations/fesm2015/animations.mjs:1124:17)

Meta Info

META: SP7.12.1 Browser – en-US – Linux i686 – Mozilla/5.0 (Linux Android 5.0 SM-G900P Build/LRX21T) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.125 Mobile Safari/537.36

Actions Before Error

1675522276786: [SP_ALL] Load(import) all data 
1675522277392: [SP_ALL] All Data was loaded 
1675522428038: [SP_ALL] Load(import) all data 
1675522428068: [SP_ALL] All Data was loaded 
1675522442081: [SP_ALL] Load(import) all data 
1675522442125: [SP_ALL] All Data was loaded

Stacktrace (pointing to localhost, latest git commit)

_convertKeyframesToObject (webpack:///node_modules/@angular/animations/fesm2015/browser.mjs:4516:28)
_convertKeyframesToObject (webpack:///node_modules/@angular/animations/fesm2015/browser.mjs:4515:18)
_triggerWebAnimation (webpack:///node_modules/@angular/animations/fesm2015/browser.mjs:4524:39)
_buildPlayer (webpack:///node_modules/@angular/animations/fesm2015/browser.mjs:4500:17)
play (webpack:///node_modules/@angular/animations/fesm2015/browser.mjs:4538:13)
play (webpack:///node_modules/@angular/animations/fesm2015/browser.mjs:4099:37)
players.filter (webpack:///node_modules/@angular/animations/fesm2015/browser.mjs:3883:19)
players.filter (webpack:///node_modules/@angular/animations/fesm2015/browser.mjs:3876:20)

Meta Info

META: SP7.12.1 Browser – en-US – Linux i686 – Mozilla/5.0 (Linux Android 5.0 SM-G900P Build/LRX21T) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.125 Mobile Safari/537.36

Actions Before Error

1675523422363: [SP_ALL] Load(import) all data 
1675523422455: [SP_ALL] All Data was loaded

Additional observations

The same error also happens inside the WebView Browser Tester (Chrome 69.0.3497.100) inside the AVD emulated Android 9.0.

@github-actions
Copy link

github-actions bot commented Feb 4, 2023

Thank you very much for opening up this issue! I am currently a bit overwhelmed by the many requests that arrive each week, so please forgive me, if I fail to respond personally. I am still very likely to at least skim read your request and I'll probably try to fix all (real) bugs if possible and I will likely review every single PR being made (please, give me a heads up if you intent to do so) and I will try to work on popular requests (please upvote via thumbs up on the original issue) whenever possible, but trying to respond to every single issue over the last years has been kind of draining and I need to adjust my approach for this project to remain fun for me and to make any progress with actually coding new stuff. Thanks for your understanding!

@github-actions
Copy link

github-actions bot commented Feb 4, 2023

Hello there lrq3000! 👋

Thank you and congratulations 🎉 for opening your very first issue in this project! 💖

In case you want to claim this issue, please comment down below! We will try to get back to you as soon as we can. 👀

For more open ended discussions and/or specific questions, please visit the discussions page. 💖

@lrq3000
Copy link
Contributor Author

lrq3000 commented Feb 4, 2023

I confirm the bug is reproducible on arguably any Android device (tested on Android 10) if we install Chrome APK v69.0.3497.100 and just try to access https://app.super-productivity.com.

I tried to revert both the super-productivity-android app to before the merges of my two filesync PRs, and also rollback super-productivity to a similarly timed commit c54b26f , this did not help. So the regression appears to have been introduced before the filesync feature.

@lrq3000
Copy link
Contributor Author

lrq3000 commented Feb 4, 2023

I tried to go as far back as commit 8a98c30 , the regression was already there.

I would suggest to recommend Android users use at least Chrome v74.0.3729.185 , as this version is the default one on Android 10 and it works fine.

This is not the primary issue behind johannesjo/super-productivity-android#36 so I stop my bug tracing here for the current issue.

Tip: update Chome using the Play Store inside a Play Store enabled AVD image, otherwise trying to install an upgraded Chrome or WebView via an APK, even an AOSP build, will result in crashes and bugs.

lrq3000 added a commit to lrq3000/super-productivity that referenced this issue Feb 5, 2023
… 9.0), fixes johannesjo#2451

Signed-off-by: Stephen L. <lrq3000@gmail.com>
johannesjo pushed a commit that referenced this issue Feb 6, 2023
… 9.0), fixes #2451

Signed-off-by: Stephen L. <lrq3000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant