Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #29

wants to merge 1 commit into from

Conversation

shatran
Copy link

@shatran shatran commented Dec 1, 2015

add a condition to 'keyboardWillShow' to fix the example

add a condition to 'keyboardWillShow' to fix the example
@johanneslumpe
Copy link
Owner

@shatran just because i'm curious: when are there events for the keyboard which do not have endCoordinates? Does it fire multiple events where one has beginCoordinates? (Haven't used the native version)

@shatran
Copy link
Author

shatran commented Dec 1, 2015

I'm not sure when exactly these events are being fired, but more than one keyboardWillShow event is being fired when keyboard is shown, and not all of them has 'endCoordinates' as a field of the event.

@johanneslumpe
Copy link
Owner

@shatran Ok - seems rather weird though. Are you sure that you are not using the keyboard events module? If you take a look at https://github.com/facebook/react-native/blob/060664fd3d9331f062696e68179bac9cd4544a06/React/Base/RCTKeyboardObserver.m#L90 you will see that all events are processsed in the same manner and all receive a dictionary for startCoordinates and endCoordinates.

@shatran
Copy link
Author

shatran commented Dec 1, 2015

It does seem weird. but maybe the 'endCoordinates' value can be null? IDK..
I did use the keyboard events module, but i've deleted it from the js section and in the build phase of the xcode project so i'm not sure how can i still be using it..
anyway it's up to you if you want to add it to the docs or not, i can only share what happened to me, not if it will definitely happen to anyone else.

@johanneslumpe
Copy link
Owner

@shatran Would be great if you were able to confirm this issue with a clean project and report back here if you have the time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants