Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Update Accessory when hostname/IP change #3

Closed
johannrichard opened this issue May 15, 2020 · 0 comments
Closed

[FIX] Update Accessory when hostname/IP change #3

johannrichard opened this issue May 15, 2020 · 0 comments
Assignees
@johannrichard
Labels
enhancement New feature or request
Projects
Homebridge Plugin

Comments

@johannrichard
Copy link
Owner

johannrichard commented May 15, 2020 •
edited

When the config is updated with a new hostname/IP, we’re not currently updating the accessory as the plugin stops the update without this being checked.

homebridge-dingz/src/platform.ts

Line 199 in 1edcc4d

if (typeof data !== 'undefined') {

We should (also) check for updates in the hostname/80 to cater for changes these.
@johannrichard johannrichard added the enhancement New feature or request label May 15, 2020
@johannrichard johannrichard self-assigned this May 15, 2020
@johannrichard johannrichard changed the title Update Accessory when hostname/IP change [FIX] Update Accessory when hostname/IP change Jun 3, 2020
@johannrichard johannrichard moved this from To do to In progress in Homebridge Plugin Nov 14, 2020
johannrichard added a commit that referenced this issue Nov 28, 2020
@johannrichard
feat(dingz): handle accessory ip address changes
896ff5b 
- update accessory if the IP changes in config or from auto-discovery
- implements #3 😄
@johannrichard johannrichard mentioned this issue Nov 28, 2020
Closed
Homebridge Plugin automation moved this from In progress to Done Nov 29, 2020
johannrichard added a commit that referenced this issue Nov 29, 2020
@johannrichard
docs(changelog): release v2.0.0
93b9fd0 
A big (**breaking**) release (see CHANGELOG.md for details).

Thanks to @granturism0, @qx54, @simonnelli for their contributions

- fixes #3,
- fixes #103,
- fixes #116,
- fixes #120,
- fixes #123,
- fixes #124,
- fixes #129,
- fixes #135

BREAKING CHANGE: check CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johannrichard johannrichard

Labels
enhancement New feature or request
Projects
Homebridge Plugin
Status: Done
Homebridge Plugin
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johannrichard