Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read WindowCoveringConfig and set correct names #129

Closed
wants to merge 8 commits into from
Closed

Read WindowCoveringConfig and set correct names #129

wants to merge 8 commits into from

Conversation

granturism0
Copy link

  • Implementation of WindowCoveringConfig
  • Setting the names for blinds using the WebGUI
  • Improvement detection of IP changes

@granturism0
Copy link
Author

Hello @johannrichard
So, sorry for the necessary style corrections, but now everything should be checked in correctly.
I have made several changes in the code so that the names of the engines are now also loaded cleanly from the web config.
Hope this fits for you :-)
Best regards
@granturism0

@granturism0
Copy link
Author

Hello @johannrichard
Yes, I notice that you are currently working on various adaptations for V2.0. If necessary, you can include my revisions in this comprehensive revision. I would be happy if this still fits.
You can send me the link to this nightly build. Then I can test the complete revisions including my adjustments again.
Best regards
@granturism0

@johannrichard
Copy link
Owner

So, sorry for the necessary style corrections, but now everything should be checked in correctly.

No worries, we're all learning and my code is far froM perfect.

I have made several changes in the code so that the names of the engines are now also loaded cleanly from the web config.

Great, makes sense and I'll have a look at it. Might integrate it slightly different into the v2.0.0-refactor branch as I have started to cleanup quite a bit the mess my code is. 😁😅

Hope this fits for you :-)

All contributions are welcome. 😃 :octocat:

@granturism0
Copy link
Author

PS: I have now also installed VSCodium.
I usually work with VS Studio on the Mac.

@johannrichard
Copy link
Owner

PS: I have now also installed VSCodium.
I usually work with VS Studio on the Mac.

Apologies if I run into open doors re:style & formatting: I vaguely remember that I had to install the esbenp.prettier-vscode extension to use Prettier specifically in Visual Studio Code/VSCodium to have consistent formatting.

ext install esbenp.prettier-vscode

@johannrichard
Copy link
Owner

Apologies if I run into open doors re:style & formatting: I vaguely remember that I had to install the esbenp.prettier-vscode extension to use Prettier specifically in Visual Studio Code/VSCodium to have consistent formatting.

As a matter of fact, I have just realised that my vscode settings in the project were somehow incomplete, too. If you pull the latest changes from the master branch, you'll get an updated .vscode/settings.json file in the project which picks up prettier as default (according to this guide). I wonder why I haven't seen that earlier. 🤦

@granturism0
Copy link
Author

PS: I have now also installed VSCodium.
I usually work with VS Studio on the Mac.

Apologies if I run into open doors re:style & formatting: I vaguely remember that I had to install the esbenp.prettier-vscode extension to use Prettier specifically in Visual Studio Code/VSCodium to have consistent formatting.

ext install esbenp.prettier-vscode

Thanks for your comments.
I have now made a few optimizations for me, so that I can at least see the styling errors in build.
But the plugin makes even more sense if you have the rules anyway.

johannrichard added a commit that referenced this pull request Nov 29, 2020
- some more index wrangling
- more fixing towards #124 and #129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants