Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] resolve tilt angle inconsistencies #124

Closed
johannrichard opened this issue Nov 22, 2020 · 0 comments
Closed

[FIX] resolve tilt angle inconsistencies #124

johannrichard opened this issue Nov 22, 2020 · 0 comments
Assignees
@johannrichard
Labels
bug Something isn't working enhancement New feature or request
Projects
Homebridge Plugin

Comments

@johannrichard
Copy link
Owner

Describe the enhancement
Update the plugin to account for changes in the dingz FW API when getting/setting the tilt angle.

Examples and context

  • The dingz firmware v1.1 used different values to set and get the lamella tilt angle (° vs %). The current code accounts for this
  • The dingz firmware v1.2consitently uses percentages, which is incompatible with the way the v1.1 firmware handles this

Additional context
See #119 for a discussion why this fix is needed and why it might eventually introduce breaking changes for dingz with older firmwares.
@johannrichard johannrichard added bug Something isn't working enhancement New feature or request labels Nov 22, 2020
@johannrichard johannrichard self-assigned this Nov 22, 2020
@johannrichard johannrichard added this to To do in Homebridge Plugin via automation Nov 22, 2020
@johannrichard johannrichard moved this from To do to In progress in Homebridge Plugin Nov 22, 2020
johannrichard added a commit that referenced this issue Nov 22, 2020
@johannrichard
fix(dingz): better fix for #124
c666340 
- update for b8d03a8
- fixes #124
@johannrichard johannrichard mentioned this issue Nov 28, 2020
Closed
johannrichard added a commit that referenced this issue Nov 29, 2020
@johannrichard
fix(dingz): blinds – it's complicated
5e9affc 
- some more index wrangling
- more fixing towards #124 and #129
Homebridge Plugin automation moved this from In progress to Done Nov 29, 2020
johannrichard added a commit that referenced this issue Nov 29, 2020
@johannrichard
docs(changelog): release v2.0.0
93b9fd0 
A big (**breaking**) release (see CHANGELOG.md for details).

Thanks to @granturism0, @qx54, @simonnelli for their contributions

- fixes #3,
- fixes #103,
- fixes #116,
- fixes #120,
- fixes #123,
- fixes #124,
- fixes #129,
- fixes #135

BREAKING CHANGE: check CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johannrichard johannrichard

Labels
bug Something isn't working enhancement New feature or request
Projects
Homebridge Plugin
Status: Done
Homebridge Plugin
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johannrichard