feature: Violating agents, allocation reasons and more #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thommann
requested changes
Sep 12, 2022
Comment on lines
90
to
91
| label: "Collisions", | ||
| value: simulation.statistics.totalNumberOfCollisions, |
There was a problem hiding this comment.
Suggested change
| label: "Collisions", | |
| value: simulation.statistics.totalNumberOfCollisions, | |
| label: "Violations", | |
| value: simulation.statistics.totalNumberOfCollisions, |
There was a problem hiding this comment.
rename property as well. Should be called violations.
There was a problem hiding this comment.
I don't get it. The API property is called "total_number_of_collisions", I name it "totalNumberOfCollisions" and display it under the title "Collisions", but you are telling me it should be called Violations?
There was a problem hiding this comment.
habs in meinem PR gefixed
Co-authored-by: thommann <34217413+thommann@users.noreply.github.com>
Comment on lines
+285
to
316
| const violationData = computed(() => { | ||
| return Object.entries(simulation.agentInFocus.violations) | ||
| .map(([agent_id, locations]) => { | ||
| return locations.map((loc) => ({ | ||
| ...loc, | ||
| agent: agent_id, | ||
| })); | ||
| }) | ||
| .flat() | ||
| .reduce((acc, violation) => { | ||
| const subtitle = `Tick ${violation.t}`; | ||
| let entryIndex = acc.findIndex((v) => v.subtitle === subtitle); | ||
| if (entryIndex === -1) { | ||
| acc.push({ | ||
| subtitle, | ||
| datapoints: [], | ||
| }); | ||
| entryIndex = acc.length - 1; | ||
| } | ||
| const agent = simulation.agents.find((a) => a.id === violation.agent); | ||
| acc[entryIndex].datapoints.push({ | ||
| label: `${agent.owner.name} > ${agent.id}`, | ||
| value: { x: violation.x, y: violation.y, z: violation.z }, | ||
| icon: GitPullRequest, | ||
| onClick: () => { | ||
| simulation.focusOnAgent(agent); | ||
| }, | ||
| }); | ||
| return acc; | ||
| }, []); | ||
| }); | ||
|
|
There was a problem hiding this comment.
cyclic complexity to hight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.