-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect tld for appspot.com (support excluding private domains on lookup) #19
Comments
I wholeheartedly agree. We should split the list and exclude private domains by default. "appspot.com" as a TLD does not fit the definition laid out in I also see the utility of the private domain list, and have long wondered how to let |
I really want this feature. Reflecting a bit though, it's debatable if this should be the default in 1.x. |
In my opinion, this should be the default. Your package is called "tldextract", and these public sufffixes are not TLDs. An From what I can see, it looks like this has confused many people trying to use this package, which further proves my point. |
Has this issue been fixed? I just downloaded the latest version and I'm still seeing the issue. Thanks. |
Nope, this is still very much an issue, reading in the entire PSL as is. I welcome a PR along the lines of my suggestion in my comment above. |
Just curious on the status of this. Are we waiting for someone to write a pull request? Is it in progress? Thanks! =) |
Nope, no progress that I'm aware of. I don't have the time or urge to do it. Again, I'd welcome a PR along the lines of my suggestion above. |
Gotcha. I'm afraid I can't use this package with full confidence until then, seeing as it doesn't quite work out of the box. I'll take a look at the code and your suggestion, see what I can come up with. |
Set include_psl_private_domains=True and update your PSL snapshot to revert to the old behavior.
Fixed. I forewent any custom inclusions/exclusions at runtime, since that complicates caching and the upstream contents. Nobody was clamoring for it anyway. You can always point to a custom PSL URL, besides. |
This long-awaited fix is now in the wild in 1.5. |
Awesome, thanks a lot, John! |
There are multiple uses of the Mozilla public suffix list which allow sites such as "appspot.com" to appear on the list as a tld instead of being split into domain="appspot" and tld="com".
This is perfectly reasonable behavior for some use cases, but for others it would be helpful to have the "private" domains be excluded. Mozilla has split the list into "ICANN Domains" and "Private Domains", and it would be useful to optionally be able to exclude the private domains so that sites like "appspot.com" would have their tld reflected as "com".
The text was updated successfully, but these errors were encountered: