updated tests to match

johnagan · Jan 7, 2021 · b2dccbb · b2dccbb
1 parent 0edf40f
commit b2dccbb
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 14 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -8,9 +8,9 @@
 
 version: 2
 jobs:
-    test-node8:
+    test-node10:
         docker:
-            - image: circleci/node:8
+            - image: circleci/node:10
         steps:
             - checkout
             - run: node --version > _node_version && npm --version > _npm_version && cat _node_version && cat _npm_version
@@ -24,9 +24,9 @@ jobs:
                       - ~/.npm
                   key: v1-dependencies-{{ checksum "_node_version" }}-{{ checksum "_npm_version" }}
             - run: npm run test.ci
-    test-node10:
+    test-node12:
         docker:
-            - image: circleci/node:10
+            - image: circleci/node:12
         steps:
             - checkout
             - run: node --version > _node_version && npm --version > _npm_version && cat _node_version && cat _npm_version
@@ -40,9 +40,9 @@ jobs:
                       - ~/.npm
                   key: v1-dependencies-{{ checksum "_node_version" }}-{{ checksum "_npm_version" }}
             - run: npm run test.ci
-    test-node12:
+    test-node14:
         docker:
-            - image: circleci/node:12
+            - image: circleci/node:14
         steps:
             - checkout
             - run: node --version > _node_version && npm --version > _npm_version && cat _node_version && cat _npm_version
@@ -61,6 +61,6 @@ workflows:
     version: 2
     build_and_test:
         jobs:
-            - test-node8
             - test-node10
             - test-node12
+            - test-node14
diff --git a/appveyor.yml b/appveyor.yml
@@ -1,8 +1,8 @@
 environment:
     matrix:
-        - nodejs_version: '8'
         - nodejs_version: '10'
         - nodejs_version: '12'
+        - nodejs_version: '14'
 platform:
     - x86
     - x64

diff --git a/dev-utils/node-version.js b/dev-utils/node-version.js
@@ -7,7 +7,7 @@ function getNodeVersion() {
     const packageJson =
         readPkgUp.sync({ cwd: process.cwd(), normalize: false }).package || {};
     const engines = packageJson.engines || {};
-    const node = engines.node || '8.9.0';
+    const node = engines.node || '10.0.0';
 
     const nodeVersion = semver.coerce(node).raw;
 

diff --git a/dev-utils/node-version.test.js b/dev-utils/node-version.test.js
@@ -7,15 +7,15 @@ test('handles undefined pkg', () => {
 
     const nodeVersion = require('./node-version');
 
-    expect(nodeVersion).toEqual('8.9.0');
+    expect(nodeVersion).toEqual('10.0.0');
 });
 
 test('handles undefined engines', () => {
     jest.doMock('read-pkg-up', () => ({ sync: () => ({ package: {} }) }));
 
     const nodeVersion = require('./node-version');
 
-    expect(nodeVersion).toEqual('8.9.0');
+    expect(nodeVersion).toEqual('10.0.0');
 });
 
 test('handles undefined node', () => {
@@ -25,7 +25,7 @@ test('handles undefined node', () => {
 
     const nodeVersion = require('./node-version');
 
-    expect(nodeVersion).toEqual('8.9.0');
+    expect(nodeVersion).toEqual('10.0.0');
 });
 
 test('handles non-digit characters', () => {
@@ -45,5 +45,5 @@ test('handles empty node', () => {
 
     const nodeVersion = require('./node-version');
 
-    expect(nodeVersion).toEqual('8.9.0');
+    expect(nodeVersion).toEqual('10.0.0');
 });
diff --git a/package.json b/package.json
@@ -11,7 +11,7 @@
     "dist/"
   ],
   "engines": {
-    "node": ">=8.9.0"
+    "node": ">=10.0.0"
   },
   "keywords": [
     "webpack",