Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanAfterEveryBuildPatterns negative patterns #112

Conversation

chrisblossom
Copy link
Collaborator

Adding negative patterns to cleanAfterEveryBuildPatterns was not excluding matching stale webpack assets. This is an issue when using this plugin with something like copy-webpack-plugin that does not persist with webpack's reported assets.

I think we should release an update to npm after merging this.

@codecov-io
Copy link

codecov-io commented Mar 13, 2019

Codecov Report

Merging #112 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #112      +/-   ##
=========================================
+ Coverage   98.64%   98.7%   +0.05%     
=========================================
  Files           1       1              
  Lines          74      77       +3     
  Branches       25      26       +1     
=========================================
+ Hits           73      76       +3     
  Misses          1       1
Impacted Files Coverage Δ
src/clean-webpack-plugin.ts 98.7% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0f798a...9d48016. Read the comment docs.

@johnagan johnagan merged commit f810047 into johnagan:master Mar 14, 2019
@johnagan
Copy link
Owner

done! good stuff ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants