Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow cleaning under external project roots #18

Merged
merged 3 commits into from
Apr 27, 2016
Merged

Allow cleaning under external project roots #18

merged 3 commits into from
Apr 27, 2016

Conversation

alextreppass
Copy link
Contributor

For discussion in #17.

  • Allow 'root' to be outside of cwd / 'project' / webpack dir.
  • Dirs to be cleaned must still be under the provided 'root' dir.

@alextreppass alextreppass mentioned this pull request Apr 6, 2016
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 94.595% when pulling b6ba9f3 on alextreppass:external-project-root into 0e88ae6 on johnagan:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 94.595% when pulling b6ba9f3 on alextreppass:external-project-root into 0e88ae6 on johnagan:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 94.595% when pulling e61cd0e on alextreppass:external-project-root into 0e88ae6 on johnagan:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 94.595% when pulling 9223d9c on alextreppass:external-project-root into 0e88ae6 on johnagan:master.

@alextreppass alextreppass changed the title [In Progress] Allow external project roots [In Progress] Allow cleaning under external project roots Apr 6, 2016
@alextreppass alextreppass changed the title [In Progress] Allow cleaning under external project roots Allow cleaning under external project roots Apr 6, 2016
chrisblossom and others added 2 commits April 12, 2016 08:47
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 94.521% when pulling 7120071 on alextreppass:external-project-root into 0e88ae6 on johnagan:master.

@johnagan johnagan merged commit cbbe4d7 into johnagan:master Apr 27, 2016
@alextreppass alextreppass deleted the external-project-root branch April 29, 2016 12:26
@chrisblossom chrisblossom mentioned this pull request Apr 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alextreppass @coveralls @johnagan @chrisblossom