Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for issue 84 #95

Merged
merged 1 commit into from Jan 22, 2019
Merged

fix for issue 84 #95

merged 1 commit into from Jan 22, 2019

Conversation

MeiKatz
Copy link
Contributor

@MeiKatz MeiKatz commented Dec 8, 2018

fix for issue #84 / ignore webpackDir when loaded as ESM module

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.051% when pulling 5e5f76a on MeiKatz:master into c9d7117 on johnagan:master.

@iAmServerless
Copy link

What is the status of this PR?

@MeiKatz
Copy link
Contributor Author

MeiKatz commented Jan 14, 2019

@ashuanindian This PR needs somebody who approves it and then it can be merged.

@johnagan
Copy link
Owner

thank you for the fix! sorry for the delay.

@johnagan johnagan merged commit e64ba87 into johnagan:master Jan 22, 2019
@MeiKatz
Copy link
Contributor Author

MeiKatz commented Jan 22, 2019

@johnagan never mind, we're all busy, aren't we?

@chrisblossom chrisblossom mentioned this pull request Mar 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MeiKatz @coveralls @iAmServerless @johnagan