Resolve issue #209, doesn't work with new "joi" package. #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e dependencies to peer dependencies
|
@johnbrett any plan for this to merge and release ? |
|
This one is the only dependency currently prevent me update to joi. |
|
This merge was published as v8.0.0. I considered this a breaking change as it required a change in dependencies. Thanks again @eric-swann-q2. @taina0407 @wy193777 please post here if any issues! |
|
Thanks for your immediate response! |
|
@wy193777 thank @eric-swann-q2, he did all the work here, I just dragged my heels, sorry all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #209 :
This lib has dependencies on @hapi/joi and @hapi/boom.
The @hapi/joi dependency in particular causes a collision when using the new joi library as joi detects two versions and throws an exception.
Solution: Instead set both of the libraries as peer dependencies for maximum flexibility and reference "joi" as opposed to "@hapi/joi" for future versions.