wrap fails for null Boolean feed

[dbachelder]

I have a Boolean field in my parcel which can sometimes be null...

the generated code fails with an NPE:

        parcel$$1 .writeBooleanArray(new boolean[] {InjectionUtil.getField(java.lang.Boolean.class, com.company.ValueObject.class, valueObject$$0, "isFeatured")});

[johncarl81]

Is the boolean[] field itself null or does it contain nulls?

[dbachelder]

It's not even a boolean[] field... the def is:

Boolean isFeatured;

[johncarl81]

Oh, I see... will fix tonight.

[johncarl81]

Now that I think about it.. I bet this is a problem for all Object version of primitives (Integer, Float, etc). We should probably have a null check for all of them.

[dbachelder]

Yeah.. I think I'm going to hit this problem quite a bit in these classes... lots of primitive wrappers..

[johncarl81]

this should do the trick: 73d8d68 Deployed under 0.2.8-SNAPSHOT. Let me know if it works for you.

[dbachelder]

Awesome! Thanks! I'll try it shortly

[dbachelder]

I think this fixed my problem... but is this generated code for an Integer correct?

        int int$$3 = parcel$$0 .readInt();
        java.lang.Long long$$0;
        if (int$$3 < 0) {
            long$$0 = null;
        } else {
            long$$0 = parcel$$0 .readLong();
        }
        listingEntity$$0 .listingId = long$$0;

That looks like I can't have negative values in an Integer field?

[dbachelder]

er.. sorry, Long

[johncarl81]

There are two variables in play here. The int value is there as a flag to determine if the Long is null or not.

        int int$$3 = parcel$$0 .readInt(); //null flag
        java.lang.Long long$$0; // eventual value
        if (int$$3 < 0) { // <- is the value null?
            long$$0 = null;
        } else { // nope...
            long$$0 = parcel$$0 .readLong();
        }
        listingEntity$$0 .listingId = long$$0;

[dbachelder]

Ahhh, duh, got it... thanks. Seems like everything is working great then!

[johncarl81]

I was thinking about defining a null constant so that this code is more readable:

        int int$$3 = parcel$$0 .readInt();
        java.lang.Long long$$0;
        if (int$$3 == IS_NULL) {
            long$$0 = null;
        } else {
            long$$0 = parcel$$0 .readLong();
        }
        listingEntity$$0 .listingId = long$$0;

I use this technique all over the place, especially in collections and arrays where -1 represents null, 0 represents empty and > 0 represents the size of the collection:

        int int$$18 = parcel$$12 .readInt();
        java.util.ArrayList<org.parceler.SubParcel> list$$4;
        if (int$$18 < 0) {
            list$$4 = null;
        } else {
            list$$4 = new java.util.ArrayList<org.parceler.SubParcel>();
            for (int int$$19 = 0; (int$$19 <int$$18); int$$19 ++) {
                list$$4 .add(...);
            }
        }
        converterTarget$$0 .parcelList = list$$4;

[dbachelder]

That certainly would have prevented my stupid question :)

[dbachelder]

Still hitting this issue in public void writeToParcel(android.os.Parcel parcel$$1, int flags):

parcel$$1 .writeBooleanArray(new boolean[] {listingEntity$$0 .isFeatured });

where isFeatured is a null Boolean

[johncarl81]

Robolectic's lack of Parcelable support is biting me... Looks like I missed
Boolean and Character. Will fix shortly.
On Mar 4, 2014 4:53 PM, "dbachelder" notifications@github.com wrote:

Still hitting this issue in public void writeToParcel(android.os.Parcel
parcel$$1, int flags):

parcel$$1 .writeBooleanArray(new boolean[] {listingEntity$$0 .isFeatured
});

where isFeatured is a null Boolean

Reply to this email directly or view it on GitHubhttps://github.com//issues/22#issuecomment-36694495
.

[johncarl81]

try again with 0.2.8-SNAPSHOT

[dbachelder]

looks good, thanks

[johncarl81]

Finally... thanks for sticking with it.