-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating or editing presets limited to 2 cells #127
Comments
7 days and no comment?? Either no one is watching the issues, or no one believes this issue. In case it is the later, I created a video: https://youtu.be/fh0Y25Fm1HM At the beginning of the video you can see that there is no current "Electric Charge Plan" preset. Then I start a charge for 1 5000mah battery at 2C. You can see at the beginning that a 6-cell battery is attached. The error "Number of cells doesn't match the setting" pops up on the charger. You can see why by looking at the Electric Charge Plan that was automatically created - It is for 7.4V (2S). |
Have patience. This is a hobby-project done on peoples free-time and not a commercial company with working support-organisation. Your issue will be looked on when they have time. |
Yep, I understand that. I at least expected that someone else, not necessarily one of the developers, would comment that they had observed the same problem. The video that is part of the readme on the main github page shows that this did work correctly at one time. I wrote software myself until I retired 14 years ago. I may look into the problem myself, but for someone who knows their way around this development environment this may be a few minute fix while it could take me many days just to "learn to walk". Thanks for your response though. It at least confirms that other people do read the issues here. I wasn't even sure that I posted in the correct place. |
cells show is fixed in upcoming beta. |
* upgrade-to-ionic4: (74 commits) fixed up colour of toast messages refactored scss to be consistently named fixed up colour of toast messages added enable/disabled to the save buttons on the preset form, where there is validation (it uses viewchild to get the form and work out if its valid) fix refreshing of presets, also checking for changes before allowing refresh. fix spinner height offset #122, confirmation that 67 is indeed the right thing fixing #123 and #127 made text bigger and fixed vertical align of channel icons stared at the config.xml a bit and fixed the ios package name got nimh charge page fixed refactored the deactivation guard so I can use it on other routes implemented 'ionCanLeave' on system page added a 'safe json stringify' added in the errors display component, so it can be poped up added a template based charger validator directive, refactored from the original so it can work in reactive form or template fixed the /unified not stopping properly when entering network config page adjust font sizing and colour for status labels tidy up error display, and make error methods more obvious re args added in a 'detail' pane for error objects, and made the calls more explicit, passing a string user readable error and the error object itself added a timeout to the 'waitForChargerConnected' observable tidy up channel component replace console.log/info/etc with this.logger make the menus responsive to connection/disconnection removed and added platform ios, because yeh, cordova got cordova build --prod working ...
Presets created in the charger with more than 2 cells show a blank when editing the preset and only "Auto", 1, and 2 are available in the pulldown. Same when creating a new preset with the app, both Android and iOS.
Edit 1: I guess I should have made it clear - the problem is that I can't create a new preset with a cell count larger than 2. This also effects the preset that is automatically created if you use the "Capacity & C" option for charging. I connected a 3-cell battery and used this option. The charger raised an error - something like, "Wrong number of cells". The automatically created preset had only 2 cells.
Edit 2: The same problem exists for the automatically created preset for "Measure IR" it is always 2-cell just like the one created for "Capacity & C".
The text was updated successfully, but these errors were encountered: