Fix partial rendering bug #7

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@theCrab

theCrab commented Mar 26, 2013

Instead of rendering the partial its looking for a template

Fix partial rendering bug
Instead of rendering the partial its looking for a template
@theCrab

This comment has been minimized.

Show comment Hide comment
@theCrab

theCrab Mar 26, 2013

Am closing this to make a proper one that will fix the problem

Why did someone mix Haml and Erb templates?

theCrab commented Mar 26, 2013

Am closing this to make a proper one that will fix the problem

Why did someone mix Haml and Erb templates?

@theCrab theCrab closed this Mar 26, 2013

@lbramos

This comment has been minimized.

Show comment Hide comment
@lbramos

lbramos Mar 27, 2013

Hi theCrab, with your tips I was able to solve a few things but now i get this error:
undefined method `hook' for #<#Class:0x007ff88f1052e0:0x007ff88ddc71b0>
From this code:
"<% content_for :sidebar do %>


    <%= hook :admin_supplier_tabs , {:current => current} do %>
    <li<%== ' class="active"' if current == "Supplier Details" %>>
    <%= link_to "Supplier Details", edit_admin_supplier_url(@supplier) %>
    "

    at: .rvm/gems/ruby-1.9.3-p392/bundler/gems/spree_suppliers-4d92ce8ef90c/app/views/spree/admin/suppliers/_supplier_tabs.html.erb where line #3 raised:

    Did you get this error also? Any ideas on how to solve it?

lbramos commented Mar 27, 2013

Hi theCrab, with your tips I was able to solve a few things but now i get this error:
undefined method `hook' for #<#Class:0x007ff88f1052e0:0x007ff88ddc71b0>
From this code:
"<% content_for :sidebar do %>


    <%= hook :admin_supplier_tabs , {:current => current} do %>
    <li<%== ' class="active"' if current == "Supplier Details" %>>
    <%= link_to "Supplier Details", edit_admin_supplier_url(@supplier) %>
    "

    at: .rvm/gems/ruby-1.9.3-p392/bundler/gems/spree_suppliers-4d92ce8ef90c/app/views/spree/admin/suppliers/_supplier_tabs.html.erb where line #3 raised:

    Did you get this error also? Any ideas on how to solve it?

@theCrab

This comment has been minimized.

Show comment Hide comment
@theCrab

theCrab Mar 27, 2013

I will look through it and see what i can do. The owner of this repo is not meintaining it because he doesn't need it. I'll fix the bugs, then you can check my fork and use that.

theCrab commented Mar 27, 2013

I will look through it and see what i can do. The owner of this repo is not meintaining it because he doesn't need it. I'll fix the bugs, then you can check my fork and use that.

@theCrab theCrab reopened this Mar 27, 2013

@johndavid400

This comment has been minimized.

Show comment Hide comment
@johndavid400

johndavid400 Mar 27, 2013

Owner

This gem was written for Spree 0.60 a few years ago and has been upgraded
for 0.70, but it is no longer being used so upgrading to 1.0 was not
important to us. I have started upgrading it to 1.0.3 and have created a
branch where the install steps will get it working, but there are several
features that Spree has removed and thus several pieces of this gem are no
longer valid and need to be removed.

I will get to it when I have time, but cannot promise that it will be
maintained.

cheers

On Wed, Mar 27, 2013 at 4:32 PM, The Crab notifications@github.com wrote:

I will look through it and see what i can do. The owner of this repo is
not meintaining it because he doesn't need it. I'll fix the bugs, then you
can check my fork and use that.


Reply to this email directly or view it on GitHubhttps://github.com/johndavid400/spree_suppliers/pull/7#issuecomment-15554493
.

Owner

johndavid400 commented Mar 27, 2013

This gem was written for Spree 0.60 a few years ago and has been upgraded
for 0.70, but it is no longer being used so upgrading to 1.0 was not
important to us. I have started upgrading it to 1.0.3 and have created a
branch where the install steps will get it working, but there are several
features that Spree has removed and thus several pieces of this gem are no
longer valid and need to be removed.

I will get to it when I have time, but cannot promise that it will be
maintained.

cheers

On Wed, Mar 27, 2013 at 4:32 PM, The Crab notifications@github.com wrote:

I will look through it and see what i can do. The owner of this repo is
not meintaining it because he doesn't need it. I'll fix the bugs, then you
can check my fork and use that.


Reply to this email directly or view it on GitHubhttps://github.com/johndavid400/spree_suppliers/pull/7#issuecomment-15554493
.

@lbramos

This comment has been minimized.

Show comment Hide comment
@lbramos

lbramos Mar 28, 2013

I understand John, and thanks for all your effort, it's been appreciated!
My idea is to adapt/change this gem so I can get the option for each vendor to have his own small store, inside the "big store"... Do you know any cases of people who have done this before? As I understand, current version of spree_suppliers allow multiple vendors but only one admin to manage all of their products (separating products, sells, payments and invoices by each vendor)... Is my assumption correct?
Do you think it can be done? Adapt this to have multiple vendors, each one with their own managing store? Do you think it's going to be a handsfull? Should I start from this extension or start one from scratch?
Thanks again for all your support guys! I'm still pretty noob at RoR so sorry for all the "dumb" questions... :)

lbramos commented Mar 28, 2013

I understand John, and thanks for all your effort, it's been appreciated!
My idea is to adapt/change this gem so I can get the option for each vendor to have his own small store, inside the "big store"... Do you know any cases of people who have done this before? As I understand, current version of spree_suppliers allow multiple vendors but only one admin to manage all of their products (separating products, sells, payments and invoices by each vendor)... Is my assumption correct?
Do you think it can be done? Adapt this to have multiple vendors, each one with their own managing store? Do you think it's going to be a handsfull? Should I start from this extension or start one from scratch?
Thanks again for all your support guys! I'm still pretty noob at RoR so sorry for all the "dumb" questions... :)

@theCrab

This comment has been minimized.

Show comment Hide comment
@theCrab

theCrab Mar 28, 2013

@lbramos,
I would like to make this extension do exactly that. It is becoming if not it is the "Highest Requested Feature" on Spree. If we could pull together a document of requirements, we can probably set aside a day/week/weekend to pair program on this or a similar extension.

@radar has written about it and suggested a few solutions. The best one I have seen will require the Postgresql Database. Read it here and check out Ryan Bigg's Gists. I cant search for it but look into his gists and you'll find it.

Read more on how to do it here and here and please if you find any more readings and resources, share them on this issue.

Thanks

theCrab

theCrab commented Mar 28, 2013

@lbramos,
I would like to make this extension do exactly that. It is becoming if not it is the "Highest Requested Feature" on Spree. If we could pull together a document of requirements, we can probably set aside a day/week/weekend to pair program on this or a similar extension.

@radar has written about it and suggested a few solutions. The best one I have seen will require the Postgresql Database. Read it here and check out Ryan Bigg's Gists. I cant search for it but look into his gists and you'll find it.

Read more on how to do it here and here and please if you find any more readings and resources, share them on this issue.

Thanks

theCrab

@lbramos

This comment has been minimized.

Show comment Hide comment
@lbramos

lbramos Mar 29, 2013

Hi
I think that's a great idea!
I'm out till Monday but I'll work on a small document explaining my idea,
then you add/change with your feedback and we start the development! I beg
that we can also find other people interested on this!

Thanks,

Luis

No dia 28/03/2013, às 12:33, The Crab notifications@github.com escreveu:

Hi Ibramos,
I would like to make this extension do exactly that. It is becoming if not
it is the "Highest Requested Feature" on Spree. If we could pull together a
document of requirements, we can probably set aside a day/week/weekend to
pair program on this or a similar extension.

@radar has written about it and suggested a few solutions. The best one I
have seen will require the Postgresql Database. Read it here and check out
Ryan Biggs Gists. I cant search for it but look into his gists and you'll
find it.

Read more on how to do it here and here and please if you find any more
readings and resources, share them on this issue.

Thanks

theCrab

On 28 Mar 2013, at 01:08, lbramos wrote:

I understand John, and thanks for all your effort, it's been appreciated!
My idea is to adapt/change this gem so I can get the option for each
vendor to have his own small store, inside the "big store"... Do you know
any cases of people who have done this before? As I understand, current
version of spree_suppliers allow multiple vendors but only one admin to
manage all of their products (separating products, sells, payments and
invoices by each vendor)... Is my assumption correct?
Do you think it can be done? Adapt this to have multiple vendors, each
one with their own managing store? Do you think it's going to be a
handsfull? Should I start from this extension or start one from scratch?
Thanks again for all your support guys! I'm still pretty noob at RoR so
sorry for all the "dumb" questions... :)


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on
GitHubhttps://github.com/johndavid400/spree_suppliers/pull/7#issuecomment-15586041
.

lbramos commented Mar 29, 2013

Hi
I think that's a great idea!
I'm out till Monday but I'll work on a small document explaining my idea,
then you add/change with your feedback and we start the development! I beg
that we can also find other people interested on this!

Thanks,

Luis

No dia 28/03/2013, às 12:33, The Crab notifications@github.com escreveu:

Hi Ibramos,
I would like to make this extension do exactly that. It is becoming if not
it is the "Highest Requested Feature" on Spree. If we could pull together a
document of requirements, we can probably set aside a day/week/weekend to
pair program on this or a similar extension.

@radar has written about it and suggested a few solutions. The best one I
have seen will require the Postgresql Database. Read it here and check out
Ryan Biggs Gists. I cant search for it but look into his gists and you'll
find it.

Read more on how to do it here and here and please if you find any more
readings and resources, share them on this issue.

Thanks

theCrab

On 28 Mar 2013, at 01:08, lbramos wrote:

I understand John, and thanks for all your effort, it's been appreciated!
My idea is to adapt/change this gem so I can get the option for each
vendor to have his own small store, inside the "big store"... Do you know
any cases of people who have done this before? As I understand, current
version of spree_suppliers allow multiple vendors but only one admin to
manage all of their products (separating products, sells, payments and
invoices by each vendor)... Is my assumption correct?
Do you think it can be done? Adapt this to have multiple vendors, each
one with their own managing store? Do you think it's going to be a
handsfull? Should I start from this extension or start one from scratch?
Thanks again for all your support guys! I'm still pretty noob at RoR so
sorry for all the "dumb" questions... :)


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on
GitHubhttps://github.com/johndavid400/spree_suppliers/pull/7#issuecomment-15586041
.

@lbramos

This comment has been minimized.

Show comment Hide comment
@lbramos

lbramos Apr 1, 2013

I still have to read everything more carefully but I think I should first post what I need to have... But should we continue this talk on this post or create something elsewhere for people to see and help us on this?

lbramos commented Apr 1, 2013

I still have to read everything more carefully but I think I should first post what I need to have... But should we continue this talk on this post or create something elsewhere for people to see and help us on this?

@lbramos

This comment has been minimized.

Show comment Hide comment
@lbramos

lbramos Apr 2, 2013

When I found out spree_suppliers it seemed to solve all my troubles, or at least, most of them…

It allowed multiple vendors, setting commissions for each sale, one single checkout (separating invoices and payments for each vendor), and a few more things…

For the rest of the text I consider two different roles;

* Site Owner - The entity that owes the main site

* Store Owner - The entity that buys/rents a store inside the main site

What it still doesn't accomplish and that I really need to, is:

* each vendor having his own store
* 
    * being able to manage it
    * 
        * creating his products
        * managing his stocks
        * managing his orders


* customizable stores
* 
    * allowing some kind of personalization of each store
    * 
        * personal logo
        * personal colors
        * personal layout


* possibility to have ads on each store
* 
    * managed by the site owner
    * 
        * with an option to disable ads on particular stores (for example, stores that subscribe the premium package)

    * managed by the store owner
    * 
        * with commissions for the site owner


* If the store owner doesn't want to have/manage his own store he can choose two options
* 
    * outsource the management of his store (by someone from the team of the site owner)
    * sell his products inside the site owner main store (basically what spree_suppliers allows now….)

* Promotion
* 
    * Allowing the store owner to choose which products he wants to stand out/promote on the site owner main store
    * Allowing the site owner to promote some products of the "sub stores"

* Newsletter
* 
    * Allowing the site owner to choose products/stores to promote on the newsletter
    * Allowing each store owner to have his own newsletter, by simply choose a number of products to manage and send to his clients/subscribers

The already existing functions should remain! I don't know if all these features should go to one or more expansions...

And you guys, what do you want from "spree_suppliers"?

lbramos commented Apr 2, 2013

When I found out spree_suppliers it seemed to solve all my troubles, or at least, most of them…

It allowed multiple vendors, setting commissions for each sale, one single checkout (separating invoices and payments for each vendor), and a few more things…

For the rest of the text I consider two different roles;

* Site Owner - The entity that owes the main site

* Store Owner - The entity that buys/rents a store inside the main site

What it still doesn't accomplish and that I really need to, is:

* each vendor having his own store
* 
    * being able to manage it
    * 
        * creating his products
        * managing his stocks
        * managing his orders


* customizable stores
* 
    * allowing some kind of personalization of each store
    * 
        * personal logo
        * personal colors
        * personal layout


* possibility to have ads on each store
* 
    * managed by the site owner
    * 
        * with an option to disable ads on particular stores (for example, stores that subscribe the premium package)

    * managed by the store owner
    * 
        * with commissions for the site owner


* If the store owner doesn't want to have/manage his own store he can choose two options
* 
    * outsource the management of his store (by someone from the team of the site owner)
    * sell his products inside the site owner main store (basically what spree_suppliers allows now….)

* Promotion
* 
    * Allowing the store owner to choose which products he wants to stand out/promote on the site owner main store
    * Allowing the site owner to promote some products of the "sub stores"

* Newsletter
* 
    * Allowing the site owner to choose products/stores to promote on the newsletter
    * Allowing each store owner to have his own newsletter, by simply choose a number of products to manage and send to his clients/subscribers

The already existing functions should remain! I don't know if all these features should go to one or more expansions...

And you guys, what do you want from "spree_suppliers"?

@theCrab

This comment has been minimized.

Show comment Hide comment
@theCrab

theCrab Apr 2, 2013

Wow.
@lbramos thanks for the info here.

Some of the additions are more UI facing than functional. I'll be happy to tinker with functional and leave the customization, ads and newsletter out. Its hard enough to get a spree shop going, and the others are already services that can be run on better apps like Mailchimp.

Thanks for the list though.

theCrab commented Apr 2, 2013

Wow.
@lbramos thanks for the info here.

Some of the additions are more UI facing than functional. I'll be happy to tinker with functional and leave the customization, ads and newsletter out. Its hard enough to get a spree shop going, and the others are already services that can be run on better apps like Mailchimp.

Thanks for the list though.

@lbramos

This comment has been minimized.

Show comment Hide comment
@lbramos

lbramos Apr 2, 2013

I know, I just wanted to put everything here... there were a couple of things missing, like vendor ranks, badges, and other stuff... but we should focus on main things! and from your side, what you would like to add?

lbramos commented Apr 2, 2013

I know, I just wanted to put everything here... there were a couple of things missing, like vendor ranks, badges, and other stuff... but we should focus on main things! and from your side, what you would like to add?

@lbramos

This comment has been minimized.

Show comment Hide comment
@lbramos

lbramos Apr 8, 2013

So, @theCrab do you want to join forces to attack this? Is there any other feature you would like to see?

lbramos commented Apr 8, 2013

So, @theCrab do you want to join forces to attack this? Is there any other feature you would like to see?

@theCrab

This comment has been minimized.

Show comment Hide comment
@theCrab

theCrab Apr 8, 2013

@lbramos yes. I'd like to work together on this. I'll look at what @johndavid400 has done then we can pick up from there. What is your Time Zone? I am GMT London.

theCrab commented Apr 8, 2013

@lbramos yes. I'd like to work together on this. I'll look at what @johndavid400 has done then we can pick up from there. What is your Time Zone? I am GMT London.

@lbramos

This comment has been minimized.

Show comment Hide comment
@lbramos

lbramos Apr 8, 2013

@theCrab me too (Portugal).

lbramos commented Apr 8, 2013

@theCrab me too (Portugal).

@theCrab

This comment has been minimized.

Show comment Hide comment
@theCrab

theCrab Apr 8, 2013

@lbramos whats the best time to do this. I work daytime. So evening is best.
Do you use the spree irc channel? If you get in there I am always in all day until 2300GMT most days. Just mention me #theCrab and I'll talk to you. we can then agree when to start. Thanks

theCrab commented Apr 8, 2013

@lbramos whats the best time to do this. I work daytime. So evening is best.
Do you use the spree irc channel? If you get in there I am always in all day until 2300GMT most days. Just mention me #theCrab and I'll talk to you. we can then agree when to start. Thanks

@lbramos

This comment has been minimized.

Show comment Hide comment
@lbramos

lbramos Apr 8, 2013

For me it's also better to work at night, so I'll see you on IRC tonight for us to start!

lbramos commented Apr 8, 2013

For me it's also better to work at night, so I'll see you on IRC tonight for us to start!

@createthis

This comment has been minimized.

Show comment Hide comment
@createthis

createthis May 13, 2013

What's the status on this, lbramos and theCrab? What progress have you made? I've got most of the 1.3.2 code up and running after 7 commits. However, I'm not seeing the ability to associate a product with a supplier. Maybe that hasn't been ported yet.

What's the status on this, lbramos and theCrab? What progress have you made? I've got most of the 1.3.2 code up and running after 7 commits. However, I'm not seeing the ability to associate a product with a supplier. Maybe that hasn't been ported yet.

@lbramos

This comment has been minimized.

Show comment Hide comment
@lbramos

lbramos May 13, 2013

Hi @createthis . We stopped with some other projects... I'll be picking this up in about 2 weeks time... Maybe we can work together then!

lbramos commented May 13, 2013

Hi @createthis . We stopped with some other projects... I'll be picking this up in about 2 weeks time... Maybe we can work together then!

@theCrab

This comment has been minimized.

Show comment Hide comment
@theCrab

theCrab May 13, 2013

@createthis Me too. Just been too busy to start off. But I'll see how I can get something going again. I guess this project will act as an inspiration.

theCrab commented May 13, 2013

@createthis Me too. Just been too busy to start off. But I'll see how I can get something going again. I guess this project will act as an inspiration.

@createthis

This comment has been minimized.

Show comment Hide comment
@createthis

createthis May 14, 2013

I'm giving up on spree_suppliers. I got it functional enough to evaluate usefulness with 1.3.2, after hours of bug fixes. My purpose is the same as yours: multi-vendor functionality. spree-suppliers doesn't do that. It did give me enough information to roll my own, however. Good luck.

I'm giving up on spree_suppliers. I got it functional enough to evaluate usefulness with 1.3.2, after hours of bug fixes. My purpose is the same as yours: multi-vendor functionality. spree-suppliers doesn't do that. It did give me enough information to roll my own, however. Good luck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment