Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang Static Analyzer warnings #1

Closed
wants to merge 1 commit into from

Conversation

andypotion
Copy link

Hey John,

It turns out that JSONKit doesn't have difficult to get around clang warnings. According to the benchmarks I ran, the changes here slows down the parsing by an extremely tiny amount, so no worries if you don't want to merge it into the mainline.

  • Andy Kim

@johnezang
Copy link
Owner

Andy,

Thanks for taking the time to look in to this.

However, I've decided to take the position that code should not be modified for the benefit of the static analyzer. At the time version 1.3 was checked in, the version of clang used to perform static analysis reported were all "false positives" and not actual problems.

In this particular case, and IMHO, I'm of the opinion that if there's a "problem", it's with clang, and not JSONKit.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants