Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor math, cell and props #312

Merged
merged 8 commits into from
Sep 24, 2023
Merged

Refactor math, cell and props #312

merged 8 commits into from
Sep 24, 2023

Conversation

johnfercher
Copy link
Owner

@johnfercher johnfercher commented Sep 24, 2023

Description

  • Refactor math to be agnostic to provider
  • Refactor cell and props to use pointers instead to copy data

Benchmark

  • min: 5008.527149, max: 6138.680649, avg: 5528.973213 (Old)
  • min: 4720.954979, max: 5639.864653, avg: 5298.453789 (New)
  • min: 6% better, max: 8.8% better, avg: 4.3% better

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (s *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Updated docs/doc.go
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Updated all examples inside internal/examples
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint and goreportcard-cli

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v2@f925b6e). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2     #312   +/-   ##
=====================================
  Coverage      ?   23.56%           
=====================================
  Files         ?       20           
  Lines         ?      968           
  Branches      ?        0           
=====================================
  Hits          ?      228           
  Misses        ?      734           
  Partials      ?        6           
Flag Coverage Δ
unittests 23.56% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher johnfercher marked this pull request as ready for review September 24, 2023 18:59
@johnfercher johnfercher changed the title V2 refactor math Refactor math, cell and props Sep 24, 2023
@johnfercher johnfercher merged commit d38470c into v2 Sep 24, 2023
5 checks passed
@johnfercher johnfercher deleted the v2-refactor-math branch September 24, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant