fix/95-barcode-proportion #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SuddenGunter, resolving the issue of barcode. What do you think about? |
Improve barcode proportions, by changing the proportion constrains. Height must be greater than 10% of the size of width and smaller than 20%.
johnferchermeli
force-pushed
the
fix/95-barcode-proportion
branch
from
fa4f325
to
31db529
Compare
Codecov Report
@@ Coverage Diff @@
## dev #96 +/- ##
==========================================
+ Coverage 95.67% 95.69% +0.02%
==========================================
Files 8 8
Lines 461 463 +2
==========================================
+ Hits 441 443 +2
Misses 16 16
Partials 4 4
Continue to review full report at Codecov.
|
johnferchermeli
changed the title
johnfercher
approved these changes
Oct 20, 2019
Merged
felix
pushed a commit
to felix/maroto
that referenced
this pull request
May 2, 2022
…portion fix/95-barcode-proportion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve barcode proportions, by changing the proportion constrains. Height must be greater than 10% of the size of width and smaller than 20%.
The barcode should be something between the two images below.
Related Issue
resolve #95
Checklist
func (s *struct) method() {}name style.go fmt github.com/johnfercher/maroto/...to format all files